Skip to content
This repository has been archived by the owner on Jun 26, 2024. It is now read-only.

Allow constant values in service.binding/name annotations in CRD #843

Closed
johnpoth opened this issue Jan 15, 2021 · 3 comments
Closed

Allow constant values in service.binding/name annotations in CRD #843

johnpoth opened this issue Jan 15, 2021 · 3 comments

Comments

@johnpoth
Copy link
Contributor

It would be cool to allow constant values in annotations so something like

service.binding/provider: postgresql

For example, the provider and type entries are recommended and can be the same across all underlying CR which warrants them to be constants. This also facilitates ad-hoc fixes. Thanks !

@pedjak
Copy link
Contributor

pedjak commented Jan 25, 2021

We follow the annotation format defined here, and it does not support something like this at the moment. Perhaps worth proposing it?

In the meantime, we can achieve the same result by defining a mapping:

mappings:
   - name: provider
     value: postgresql    

@johnpoth
Copy link
Contributor Author

johnpoth commented Feb 5, 2021

Thanks @pedjak for the workaround! Proposed the enhancement

@pedjak
Copy link
Contributor

pedjak commented Jul 15, 2021

Also, with #985 it is possible to specify .type and .provider directly on service binding resource.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants