Make sure to return nil value when there was an error #1079
Conversation
kadel
force-pushed
the
fix-CustomResourceDefinition
branch
from
4db3bd8
to
c49634e
Compare
Codecov Report
@@ Coverage Diff @@
## master #1079 +/- ##
==========================================
+ Coverage 58.87% 58.92% +0.04%
==========================================
Files 30 30
Lines 1668 1670 +2
==========================================
+ Hits 982 984 +2
Misses 560 560
Partials 126 126
Continue to review full report at Codecov.
|
| Expect(err).NotTo(HaveOccurred()) | ||
|
|
||
| res, err := service.CustomResourceDefinition() | ||
| Expect(err).To(HaveOccurred()) |
There was a problem hiding this comment.
the error should occur and should be the very same that gets returned in line 100.
When CrdReader fail and returns error other than NotFound service.CustomResourceDefinition should return 'nil' instead of CRD that might be invalid. Signed-off-by: Tomas Kral <tkral@redhat.com>
kadel
force-pushed
the
fix-CustomResourceDefinition
branch
from
7228c97
to
fe89a3e
Compare
done. thx for review. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pedjak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Motivation
Saving service crd (
s.crd) when there was an error while retrieving it (s.CrdReader(s.groupVersionResource)) can lead tonilpointer problems.This was causing problem for odo when it tried to use SBO as a library.
Changes
Return error and don't save crd to
s.crd.Testing
Added a test that covers this scenario.
For further more details refer the CONTRIBUTING.md
Release Notes
Before this update, when the Service Binding Operator was used as a library, there was an error while retrieving a service custom resource definition (CRD). This situation could lead to
nilpointer problems and crash the Operator. With this update, the issue is resolved and the Operator is made more stable.