Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check to verfiy that PR has not more than a single commit #1120

Merged
merged 1 commit into from Mar 21, 2022

Conversation

pmacik
Copy link
Contributor

@pmacik pmacik commented Mar 15, 2022

Signed-off-by: Pavel Macík pavel.macik@gmail.com

Changes

Currently, we encourage contributors to keep PRs with a single commit. For instance:

This PR:

  • Introduces a simple PR check to verify automatically that a PR does not have more than 1 commit.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs
    included if any changes are user facing
  • Tests
    included if any functionality added or changed. For bugfixes please include tests that can catch regressions
  • Follows the commit message standard

Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
@pmacik pmacik added kind/enhancement New feature or request ci CI related issues labels Mar 15, 2022
@openshift-ci openshift-ci bot requested review from baijum and sadlerap March 15, 2022 07:43
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 15, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from pmacik after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pmacik pmacik changed the title Add check for single commit PR Add check to verfiy that PR has not more than a single commit Mar 15, 2022
@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #1120 (eec5246) into master (31151ab) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1120   +/-   ##
=======================================
  Coverage   58.92%   58.92%           
=======================================
  Files          30       30           
  Lines        1670     1670           
=======================================
  Hits          984      984           
  Misses        560      560           
  Partials      126      126           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31151ab...eec5246. Read the comment docs.

@baijum
Copy link
Member

baijum commented Mar 16, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 16, 2022
@pmacik pmacik merged commit f626241 into redhat-developer:master Mar 21, 2022
@pmacik pmacik deleted the single-commit-check branch May 11, 2022 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci CI related issues kind/enhancement New feature or request lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants