Skip running acceptance tests in GH workflows for PR that does not change SBO nor the testing framework #1150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmacik
added
kind/enhancement
|
/hold |
pmacik
changed the title
pmacik
force-pushed
the
gha-optional-at
branch
6 times, most recently
from
61c51f9
to
db30a9b
Compare
pmacik
changed the title
pmacik
changed the title
pmacik
changed the title
pmacik
changed the title
|
/retest |
1 similar comment
|
/retest |
pmacik
force-pushed
the
gha-optional-at
branch
7 times, most recently
from
49275e8
to
5645687
Compare
pmacik
force-pushed
the
gha-optional-at
branch
3 times, most recently
from
e93ea2f
to
fe421ef
Compare
pmacik
changed the title
|
/unhold |
… testing framework Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
|
Some questions:
|
|
Yes, this PR only affects GH Actions, Prow jobs (OpenShift CI) are separated in openshift/release#28875 So, until the above PR is merged, the Prow jobs would run as before. |
pmacik
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1150 +/- ##
=======================================
Coverage 57.84% 57.84%
=======================================
Files 31 31
Lines 2697 2697
=======================================
Hits 1560 1560
Misses 976 976
Partials 161 161 Continue to review full report at Codecov.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sadlerap The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pavel Macík pavel.macik@gmail.com
Changes
Currently, the acceptance tests are executed for any and each PR - even for those that for example affects only the docs. In such cases there is no need to actually execute the acceptnace tests as the resulting SBO images as well as the testing framework (incl. scenarios) are exactly the same as those already tested and merged in master.
Not running the acceptance tests for PRs that do not inflict any testable changes would save time significantly to merge such PRs as well as saving resources
Ref: https://issues.redhat.com/browse/APPSVC-1116
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
included if any changes are user facing
included if any functionality added or changed. For bugfixes please include tests that can catch regressions
@external-feedbacktag.