-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add/Remove acceptance-tests-skipped label for PRs #1155
Add/Remove acceptance-tests-skipped label for PRs #1155
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1155 +/- ##
=======================================
Coverage 57.84% 57.84%
=======================================
Files 31 31
Lines 2697 2697
=======================================
Hits 1560 1560
Misses 976 976
Partials 161 161 Continue to review full report at Codecov.
|
0444dc7
to
1b79a0f
Compare
Setting a label for PRs wouldn't work with |
69c7553
to
ea0c7ed
Compare
@pmacik just curious: did you consider using https://github.com/actions/labeler instead of writing the custom action? |
Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
ea0c7ed
to
8b056e8
Compare
@pedjak Hey, thanks for that suggestion! I have considered it, yes. If I only wanted to set labels based on the content, I'd use it. But in this case, setting a label is a follow-up to #1150 where I primarily wanted to selectively skip the acceptance tests based on PR content. For that I considered using the path filtering, however, I couldn't use that because the checks are Required, so I wrote a custom action for that. This PR extend that custom action by setting the label to inform about the test skipping. Of course, I could use the 'labeler' action for that, but then I'd need to keep and maintain the path filter at 2 places - one in the custom action, which is already in place, and the second in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dperaza4dustbit The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Pavel Macík pavel.macik@gmail.com
Follow-up to: #1150
Changes
This PR:
check-skip-acceptance-tests
GitHub Action to be able to set or unset the specified label on a PR that can skip (or can't skip resp.)pull_request_target
scoped workflow using that action to set or unsetacceptance-tests-skipped
labelSubmitter Checklist
As the author of this PR, please check off the items in this checklist:
included if any changes are user facing
included if any functionality added or changed. For bugfixes please include tests that can catch regressions
@external-feedback
tag.