Skip to content
This repository has been archived by the owner on Jun 26, 2024. It is now read-only.

bump helm chart to v1.4.1 #1528

Merged
merged 1 commit into from
Nov 13, 2023
Merged

bump helm chart to v1.4.1 #1528

merged 1 commit into from
Nov 13, 2023

Conversation

sadlerap
Copy link
Contributor

@sadlerap sadlerap commented Nov 7, 2023

Changes

/kind enhancement

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs
    included if any changes are user facing
  • Tests
    included if any functionality added or changed. For bugfixes please include tests that can catch regressions
  • All acceptance test scenarios included in the PR which verifies a bugfix or a requested feature reported by a non-member are tagged with @external-feedback tag.
  • Follows the commit message standard

@openshift-ci openshift-ci bot added the kind/enhancement New feature or request label Nov 7, 2023
@github-actions github-actions bot added the acceptance-tests-skipped Marks PR that does not need to run the acceptance tests label Nov 7, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 7, 2023 •
edited
Loading

Codecov Report

Merging #1528 (1d1490e) into master (c155782) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1528   +/-   ##
=======================================
  Coverage   58.16%   58.16%           
=======================================
  Files          35       35           
  Lines        3014     3014           
=======================================
  Hits         1753     1753           
  Misses       1093     1093           
  Partials      168      168

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c155782...1d1490e. Read the comment docs.

@Kartikey-star
Copy link
Contributor

@sadlerap are we not missing an update on the image on template/deployment.yaml?

@sadlerap
bump helm chart to v1.4.1
1d1490e 
Signed-off-by: Andy Sadler <ansadler@redhat.com>
@sadlerap
Copy link
Contributor Author

sadlerap commented Nov 9, 2023

@Kartikey-star Fixed with 1d1490e.

Kartikey-star
Kartikey-star approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@Kartikey-star Kartikey-star left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sadlerap sadlerap added the release/v1.4.x Used to mark PRs to be cherry-picked in release-v1.4.x branch label Nov 13, 2023
filariow
filariow approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@filariow filariow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@filariow
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Nov 13, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: filariow

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 98b355d into redhat-developer:master Nov 13, 2023
19 checks passed
service-binding-operator-bot pushed a commit to service-binding-operator-bot/service-binding-operator that referenced this pull request Nov 13, 2023
@sadlerap @web-flow
bump helm chart to v1.4.1 (redhat-developer#1528)
577db4d 
Signed-off-by: Andy Sadler <ansadler@redhat.com>
@sadlerap sadlerap deleted the bump-helm-chart branch November 13, 2023 17:10
openshift-merge-bot bot pushed a commit that referenced this pull request Nov 13, 2023
@service-binding-operator-bot @sadlerap
bump helm chart to v1.4.1 (#1528) (#1531)
2a6b491 
Signed-off-by: Andy Sadler <ansadler@redhat.com>
Co-authored-by: Andy Sadler <ansadler@redhat.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@filariow filariow filariow approved these changes

@Kartikey-star Kartikey-star Kartikey-star approved these changes

@baijum baijum Awaiting requested review from baijum

Assignees

@filariow filariow

Labels
acceptance-tests-skipped Marks PR that does not need to run the acceptance tests approved kind/enhancement New feature or request lgtm release/v1.4.x Used to mark PRs to be cherry-picked in release-v1.4.x branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sadlerap @Kartikey-star @filariow