[testing] Acceptance tests for rhoas_kafka #24
Conversation
juandspy
force-pushed
the
test-rhoas-kafka
branch
from
5dd619f
to
d13579e
Compare
jackdelahunt
force-pushed
the
main
branch
4 times, most recently
from
1e691e7
to
5f89c15
Compare
| if !strings.Contains(err.Error(), "not found") { | ||
| return diag.FromErr(errors.Wrapf(err, "Error waiting for example instance (%s) to be deleted", d.Id())) | ||
| } |
There was a problem hiding this comment.
Maybe I am missing something here but why do we not care about the error if it contains "not found"
There was a problem hiding this comment.
I found that sometimes the API returns an error "not found" when the resource has been deleted and the terraform provider fails. So I thought that a "not found" is OK if we are deleting the resource
There was a problem hiding this comment.
Okay this is kind of weird but maybe there is no way around it.
| if err1.Error() == "404 Not Found" { | ||
| return data, "404", nil | ||
| } |
There was a problem hiding this comment.
Why are we checking this just not sure? Also we will do more error handling in the future anyway so nothing needs to be perfect right now.
There was a problem hiding this comment.
Similarly to this comment, I discovered that sometimes the API returns a "404 Not Found" and the delete function errors. I think that if we get a 404, there shouldn't be any error, as not finding the resource means it has been deleted.
There was a problem hiding this comment.
Cool, bit weird but as I said not sure how to get around it right now.
…-rhoas into test-rhoas-kafka
Summary
Added some acceptance tests for
rhoas_kafka:TestAccRHOASKafka_Basic: checks that we are able to spin up a Kafka cluster and delete it.TestAccRHOASKafka_Update: checks that we are able to spin up a Kafka cluster, change its name and delete it.TestAccRHOASKafka_Error: checks that an error is returned if the configuration is wrong. For example, if the cloud provider isn't supported.Testing
Run
make testacc. You have to export yourOFFLINE_TOKENvariable first.