Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[testing] Acceptance tests for rhoas_topic #29

Merged
merged 8 commits into from
Sep 29, 2022

Conversation

juandspy
Copy link
Collaborator

Summary

Added some acceptance tests for rhoas_topic. The tests are the same as in #24 and #26:

  • TestAccRHOASTopic_Basic: checks that we are able to create a topic and delete it.
  • TestAccRHOASTopic_Update: checks that we are able to create topic, change its name and delete it.
    • This one is failing because updating the name makes the resource to be replaced, so the ID is different.
    • This is because the update function is not yet implemented.
    • I left this one skipped waiting for the update feature to come.
  • TestAccRHOASTopic_Error: checks that an error is returned if the configuration is wrong. For example, if the name is empty.

I also updated the example as it was outdated.

Testing

Run make testacc. You have to export your OFFLINE_TOKEN variable first.

Copy link
Contributor

@jackdelahunt jackdelahunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jackdelahunt jackdelahunt merged commit 4f26c0b into redhat-developer:main Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants