-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test][datasource] serviceaccount #31
Merged
jackdelahunt
merged 12 commits into
redhat-developer:main
from
juandspy:test-datasources-serviceaccount
Oct 17, 2022
Merged
[test][datasource] serviceaccount #31
jackdelahunt
merged 12 commits into
redhat-developer:main
from
juandspy:test-datasources-serviceaccount
Oct 17, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@jackdelahunt I think we are missing the "client_secret": {
Type: schema.TypeString,
Computed: true,
Description: "The client secret associated with the service account. It must be stored by the client as the server will not return it after creation",
},
But I think we have access to it. Am I wrong? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added a
TestAccRHOASServiceAccount_DataSource
to check if under this configuration:the
data.rhoas_service_account.test
contains the same attributes as therhoas_service_account.foo
.Testing
Run
make testacc
.