Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test][datasource] serviceaccount #31

Merged

Conversation

juandspy
Copy link
Collaborator

Summary

Added a TestAccRHOASServiceAccount_DataSource to check if under this configuration:

resource "rhoas_service_account" "foo" {
  name = "blah blah"
}

data "rhoas_service_account" "test" {
	id = rhoas_service_account.foo.id
}

the data.rhoas_service_account.test contains the same attributes as the rhoas_service_account.foo.

Testing

Run make testacc.

@juandspy
Copy link
Collaborator Author

@jackdelahunt I think we are missing the client_secret for the service account. It is not set in any place of the code. Also, the description of that attribute says:

"client_secret": {
	Type:        schema.TypeString,
	Computed:    true,
	Description: "The client secret associated with the service account. It must be stored by the client as the server will not return it after creation",
},

It must be stored by the client as the server will not return it after creation

But I think we have access to it. Am I wrong?

@juandspy juandspy marked this pull request as ready for review September 30, 2022 14:30
@juandspy juandspy marked this pull request as draft October 17, 2022 10:10
@juandspy juandspy marked this pull request as ready for review October 17, 2022 11:04
@jackdelahunt jackdelahunt merged commit 14db703 into redhat-developer:main Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants