Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use java:serverMode to avoid conflicts #1504

Merged
merged 3 commits into from
Jun 29, 2020

Conversation

jdneo
Copy link
Collaborator

@jdneo jdneo commented Jun 28, 2020

Since the context value is shared between all the extensions. Other extensions can leverage this value in the when clause in the package.json.

It would be better to call it java:serverMode to avoid conflicts.

Signed-off-by: Sheng Chen sheche@microsoft.com

Signed-off-by: Sheng Chen <sheche@microsoft.com>
src/extension.ts Outdated Show resolved Hide resolved
src/extension.ts Outdated Show resolved Hide resolved
Signed-off-by: Sheng Chen <sheche@microsoft.com>
src/extension.ts Outdated Show resolved Hide resolved
Signed-off-by: Sheng Chen <sheche@microsoft.com>
@fbricon fbricon merged commit 79fb90d into redhat-developer:master Jun 29, 2020
@fbricon
Copy link
Collaborator

fbricon commented Jun 29, 2020

Thanks @jdneo

@fbricon fbricon added this to the End June 2020 milestone Jun 29, 2020
@jdneo jdneo deleted the cs/context-value branch June 29, 2020 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants