feat: Adopt the Java Language Server's new API#1019
Merged
Conversation
Member
jdneo
commented
Jun 22, 2020
jdneo
commented
Eskibear
reviewed
Jun 22, 2020
| { | ||
| "command": "java.test.explorer.runAll", | ||
| "when": "view == testExplorer", | ||
| "when": "view == testExplorer && serverMode != LightWeight", |
Member
There was a problem hiding this comment.
As we dicussed before, there's potential risk that the name of this context value, serverMode, conflicts with other extensions or vscode itself. And here it seems to depend on redhat.java to set this context value.
As it's available to fetch serverMode thru extension.api, I suggest to set context value in this extension, with some identifier like java-test:serverMode, just as GitLens is doing.
But the cons are:
- other extensions also have to define duplicate context values.
- the name is confusing, indicating that
serverModebelongs to test runner (but not true).
Member
Author
There was a problem hiding this comment.
Or rename the serverMode to java:serverMode in the upstream once the confliction occurs?
akaroml
approved these changes
Jul 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.