Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a user I initially couldn't find "Change Active Project" #3812

Closed
adietish opened this issue Jan 17, 2024 · 5 comments · Fixed by #3887
Closed

As a user I initially couldn't find "Change Active Project" #3812

adietish opened this issue Jan 17, 2024 · 5 comments · Fixed by #3887
Assignees
Labels
kind/enhancement New feature or request
Milestone

Comments

@adietish
Copy link
Contributor

adietish commented Jan 17, 2024

I suggest to

  • add "Change Active Project" to the context menu of the cluster- and project-node in the tree.
  • use a more intuitive icon than the 2 arrows.

This would improve user friendlyness I think. Here's how I was behaving/thinking as a noob user:

When I tried to switch the current project/namespace, I looked into the context menu but didnt find it. So I thought that the extension doesn't have this functionality. I then noticed the 2 arrows to the right of the cluster- and project node and thought that it was about refreshing or syncing. When I then clicked on it I found out that this was the functionality I was looking for.

@adietish adietish added the kind/enhancement New feature or request label Jan 17, 2024
@datho7561
Copy link
Contributor

datho7561 commented Jan 18, 2024

  • I think removing the "change project" on the cluster is a good idea
  • we should check if vscode-k8s already has something in the toolbar UPDATE it does, it might not be worth replicating this if both vscode-openshift and vscode-kubernetes are installed
  • we should check if there is enough room on the toolbar to add a new item for the project

@vrubezhny vrubezhny self-assigned this Jan 31, 2024
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Feb 6, 2024
…veloper#3812

In Application Explorer this:
- removes 'Change Active Project' inline action from the Cluster tree item (but it's still shown
  for the Project tree item);
- Adds 'Change Active Project' context menu item to the Cluster and Project tree items context menu.

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
@vrubezhny
Copy link
Contributor

vrubezhny commented Feb 6, 2024

I've just added a draft PR that in Application Explorer this:

  • removes 'Change Active Project' inline action from the Cluster tree item (but it's still shown for the Project tree item);
  • adds 'Change Active Project' context menu item to the Cluster and Project tree items context menu.

Screenshot from 2024-02-06 19-15-00 Screenshot from 2024-02-06 19-15-32

I searched thrught the 'standard' vscode icons but I couldn't find any acceptable icon to be a replacement for image...
The only icons I can find for "changing/replacing/sync something" are:
compare-changes / find-replace / find-replace-all / sync but these don't look like have anything common with switching a project (image)...
I see the only like references might have something similar. to project icon and meaning "change"..

Any ideas on where can I search for more options here?

@vrubezhny
Copy link
Contributor

  • we should check if vscode-k8s already has something in the toolbar UPDATE it does, it might not be worth replicating this if both vscode-openshift and vscode-kubernetes are installed
  • we should check if there is enough room on the toolbar to add a new item for the project

I don't think we should do anything with Cluster And Port Status Bar items but the Namespace one doesn't look like is working correctly (all these items come from the ms-kubernetes-tools.vscode-kubernetes-tools extension):

image

Alternatively we can provide our own Namespace status bar item for displaying/changing the active project/namespace, but if we do so we'll have to always disable the same status bar item from the k8s extension (by tuning up its visibility preference) and then control its accidental appearance when a user changes the k8s visibility preference for this item)

vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Feb 14, 2024
…veloper#3812

In Application Explorer this:
- removes 'Change Active Project' inline action from the Cluster tree item (but it's still shown
  for the Project tree item);
- Adds 'Change Active Project' context menu item to the Cluster and Project tree items context menu.
- Disables the k8s Context and Namespace status bar items and adds the similar OpenShift Tools own items
  that use OpenShift Tools own actions to switch context/change current project

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
@vrubezhny
Copy link
Contributor

The current draft PR replaces the k8s extension's Context and Namespace status bar informers/pickers with the same ones from OpenShift Tools extension:

Screencast.from.2024-02-14.18-59-49.webm

@vrubezhny
Copy link
Contributor

In order to make Port Forwards Status Bar informer/action we'll need to implement Port Forward IU, like:

  • Actions to add/remove port forwards
    image
  • Ports view or similar UI
    image
  • the Ports Status Bar indicator (with the action to open the Ports view
    image

I'd suggest creating a separate issue for this in case we need this functionality to be supported in OS Tools

vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Feb 15, 2024
…veloper#3812

In Application Explorer this:
- removes 'Change Active Project' inline action from the Cluster tree item (but it's still shown
  for the Project tree item);
- Adds 'Change Active Project' context menu item to the Cluster and Project tree items context menu.
- Disables the k8s Context and Namespace status bar items and adds the similar OpenShift Tools own items
  that use OpenShift Tools own actions to switch context/change current project

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Feb 16, 2024
…veloper#3812

In Application Explorer this:
- removes 'Change Active Project' inline action from the Cluster tree item (but it's still shown
  for the Project tree item);
- Adds 'Change Active Project' context menu item to the Cluster and Project tree items context menu.
- Disables the k8s Context and Namespace status bar items and adds the similar OpenShift Tools own items
  that use OpenShift Tools own actions to switch context/change current project

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Feb 16, 2024
…veloper#3812

In Application Explorer this:
- removes 'Change Active Project' inline action from the Cluster tree item (but it's still shown
  for the Project tree item);
- Adds 'Change Active Project' context menu item to the Cluster and Project tree items context menu.
- Disables the k8s Context and Namespace status bar items and adds the similar OpenShift Tools own items
  that use OpenShift Tools own actions to switch context/change current project

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
@datho7561 datho7561 added this to the 1.12.0 milestone Feb 16, 2024
datho7561 pushed a commit that referenced this issue Feb 16, 2024
In Application Explorer this:
- removes 'Change Active Project' inline action from the Cluster tree item (but it's still shown
  for the Project tree item);
- Adds 'Change Active Project' context menu item to the Cluster and Project tree items context menu.
- Disables the k8s Context and Namespace status bar items and adds the similar OpenShift Tools own items
  that use OpenShift Tools own actions to switch context/change current project

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants