Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a user I initially couldn't find "Change Active Project" #3812 #3887

Conversation

vrubezhny
Copy link
Contributor

@vrubezhny vrubezhny commented Feb 6, 2024

In Application Explorer this:

  • removes 'Change Active Project' inline action from the Cluster tree item (but it's still shown for the Project tree item);
  • Adds 'Change Active Project' context menu item to the Cluster and Project tree items context menu.
  • Disables the k8s Context and Namespace status bar items and adds the similar OpenShift Tools own items that use OpenShift Tools own actions to switch context/change current project

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (da60441) 32.37% compared to head (ed500e2) 45.45%.
Report is 43 commits behind head on main.

Files Patch % Lines
src/extension.ts 80.64% 6 Missing ⚠️
src/explorer.ts 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3887       +/-   ##
===========================================
+ Coverage   32.37%   45.45%   +13.08%     
===========================================
  Files          85       85               
  Lines        6505     6560       +55     
  Branches     1349     1355        +6     
===========================================
+ Hits         2106     2982      +876     
+ Misses       4399     3578      -821     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vrubezhny vrubezhny force-pushed the fix-set-active-project-only-on-project-and-its-context-menu branch 3 times, most recently from 1338163 to 691dbae Compare February 16, 2024 18:21
…veloper#3812

In Application Explorer this:
- removes 'Change Active Project' inline action from the Cluster tree item (but it's still shown
  for the Project tree item);
- Adds 'Change Active Project' context menu item to the Cluster and Project tree items context menu.
- Disables the k8s Context and Namespace status bar items and adds the similar OpenShift Tools own items
  that use OpenShift Tools own actions to switch context/change current project

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
@vrubezhny vrubezhny force-pushed the fix-set-active-project-only-on-project-and-its-context-menu branch from 691dbae to ed500e2 Compare February 16, 2024 18:26
@vrubezhny vrubezhny marked this pull request as ready for review February 16, 2024 19:13
@vrubezhny vrubezhny linked an issue Feb 16, 2024 that may be closed by this pull request
Copy link
Collaborator

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works great! Thanks, Victor!

@datho7561 datho7561 merged commit ee3c7dc into redhat-developer:main Feb 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As a user I initially couldn't find "Change Active Project"
2 participants