Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure icon code is not propagated in context switching (fix #990) #1018

Closed
wants to merge 1 commit into from

Conversation

jrichter1
Copy link
Contributor

No description provided.

@mohitsuman
Copy link
Collaborator

@jrichter1 I am gonna change this logic and and replace the context switch to explorer tree. Will link the PR for this.

@codecov
Copy link

codecov bot commented Aug 7, 2019

Codecov Report

Merging #1018 into master will decrease coverage by 0.09%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1018     +/-   ##
=========================================
- Coverage   86.83%   86.73%   -0.1%     
=========================================
  Files          30       30             
  Lines        1944     1945      +1     
  Branches      339      339             
=========================================
- Hits         1688     1687      -1     
- Misses        256      258      +2
Impacted Files Coverage Δ
src/openshift/cluster.ts 91.11% <0%> (-0.68%) ⬇️
src/util/watch.ts 96.55% <0%> (-3.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fc05e5...847cc1e. Read the comment docs.

@dgolovin
Copy link
Collaborator

dgolovin commented Aug 8, 2019

Will be fixed in #1019.

@dgolovin dgolovin closed this Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants