Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Create Serverless function UI test #3626

Merged
merged 2 commits into from
Jan 3, 2024

Conversation

lgrossma
Copy link
Contributor

see: #3563

Copy link

codecov bot commented Nov 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (95a3f6f) 33.20% compared to head (6be8a03) 33.20%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3626   +/-   ##
=======================================
  Coverage   33.20%   33.20%           
=======================================
  Files          84       84           
  Lines        6159     6159           
  Branches     1258     1258           
=======================================
  Hits         2045     2045           
  Misses       4114     4114           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Lukas Grossmann <lgrossma@redhat.com>
Signed-off-by: Lukas Grossmann <lgrossma@redhat.com>
@lgrossma lgrossma marked this pull request as ready for review December 18, 2023 09:23
@datho7561
Copy link
Collaborator

In order to get the tests working, I needed to make this change: #3772 . I think we should merge that change first. If I apply that change to this branch, then the tests pass.

Copy link
Collaborator

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great for me!

@datho7561 datho7561 merged commit 42dbd26 into redhat-developer:main Jan 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants