Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display notification when logging into the cluster succeeds #3772

Merged

Conversation

datho7561
Copy link
Collaborator

The message string wasn't being returned properly. This is a regression that the cluster tests caught.

Signed-off-by: David Thompson davthomp@redhat.com

The message string wasn't being returned properly.
This is a regression that the cluster tests caught.

Signed-off-by: David Thompson <davthomp@redhat.com>
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (0f31830) 33.20% compared to head (f89bd99) 33.20%.

Files Patch % Lines
src/openshift/cluster.ts 20.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3772   +/-   ##
=======================================
  Coverage   33.20%   33.20%           
=======================================
  Files          84       84           
  Lines        6159     6159           
  Branches     1258     1258           
=======================================
  Hits         2045     2045           
  Misses       4114     4114           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@vrubezhny vrubezhny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me,
Please merge

@datho7561 datho7561 merged commit 748e29a into redhat-developer:main Jan 3, 2024
5 of 6 checks passed
@datho7561 datho7561 deleted the fix-no-success-notification branch January 3, 2024 13:53
@datho7561 datho7561 added this to the 1.11.0 milestone Jan 3, 2024
@adietish adietish assigned adietish and unassigned adietish Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants