Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage client snippet on server side #119

Closed
angelozerr opened this issue Oct 18, 2019 · 4 comments · Fixed by redhat-developer/quarkus-ls#251 or #228
Closed

Manage client snippet on server side #119

angelozerr opened this issue Oct 18, 2019 · 4 comments · Fixed by redhat-developer/quarkus-ls#251 or #228
Assignees
Labels
enhancement New feature or request snippets
Milestone

Comments

@angelozerr
Copy link
Contributor

Today snippet are managed on client side, but it doesn't take care of the classpath. For instance you have qj in the completion (Configure a Jaeger tracer) although your project could not have Quarkus Jaeger dependency.

I think JDT LS provides now a support for Eclipse template, we should manage snippet with Eclipse template (on server side) and I think we could check if the project has Jaeger dependency.

@fbricon
Copy link
Collaborator

fbricon commented Oct 18, 2019

This requires allowing for template contributions on the jdt.ls side, which is not opened yet.

@angelozerr
Copy link
Contributor Author

Yes sure @fbricon it's just an idea for the future.

@angelozerr
Copy link
Contributor Author

angelozerr commented Oct 24, 2019

@fbricon I did that in my POC with maven XML extension (for dependencies). I think we can have a generic SnippetRegistry which manage any JSON vscode snippet on server side but with a context condition. I did that

In Quarkus context, the condition is the extension name.

@angelozerr
Copy link
Contributor Author

An another usecase is for completion value, those snippets should not appear:

image

Managing snippet on server side will fix that too.

angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Mar 16, 2020
Fixes redhat-developer/vscode-quarkus#119

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to angelozerr/vscode-quarkus that referenced this issue Mar 16, 2020
Fixes redhat-developer#119

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Mar 18, 2020
Fixes redhat-developer/vscode-quarkus#119

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Mar 19, 2020
Fixes redhat-developer/vscode-quarkus#119

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Mar 19, 2020
Fixes redhat-developer/vscode-quarkus#119

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Mar 19, 2020
Fixes redhat-developer/vscode-quarkus#119

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Mar 19, 2020
Fixes redhat-developer/vscode-quarkus#119

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Mar 20, 2020
Fixes redhat-developer/vscode-quarkus#119

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Mar 20, 2020
Fixes redhat-developer/vscode-quarkus#119

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Mar 20, 2020
Fixes redhat-developer/vscode-quarkus#119

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Mar 20, 2020
Fixes redhat-developer/vscode-quarkus#119

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Mar 20, 2020
Fixes redhat-developer/vscode-quarkus#119

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Mar 20, 2020
Fixes redhat-developer/vscode-quarkus#119

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Mar 21, 2020
Fixes redhat-developer/vscode-quarkus#119

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Mar 22, 2020
Fixes redhat-developer/vscode-quarkus#119

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Mar 22, 2020
Fixes redhat-developer/vscode-quarkus#119

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Mar 22, 2020
Fixes redhat-developer/vscode-quarkus#119

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Mar 23, 2020
Fixes redhat-developer/vscode-quarkus#119

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to angelozerr/vscode-quarkus that referenced this issue Mar 23, 2020
Fixes redhat-developer#119

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Mar 23, 2020
Fixes redhat-developer/vscode-quarkus#119

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Mar 23, 2020
Fixes redhat-developer/vscode-quarkus#119

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Mar 23, 2020
Fixes redhat-developer/vscode-quarkus#119

Signed-off-by: azerr <azerr@redhat.com>
@angelozerr angelozerr added enhancement New feature or request snippets labels Mar 23, 2020
@angelozerr angelozerr added this to the 1.4.0 milestone Mar 23, 2020
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Mar 23, 2020
Fixes redhat-developer/vscode-quarkus#119

Signed-off-by: azerr <azerr@redhat.com>
xorye pushed a commit to redhat-developer/quarkus-ls that referenced this issue Mar 23, 2020
Fixes redhat-developer/vscode-quarkus#119

Signed-off-by: azerr <azerr@redhat.com>
xorye pushed a commit that referenced this issue Mar 23, 2020
Fixes #119

Signed-off-by: azerr <azerr@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request snippets
Projects
None yet
2 participants