Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for MicroProfile Fault Tolerance #174

Closed
angelozerr opened this issue Dec 12, 2019 · 3 comments
Closed

Add support for MicroProfile Fault Tolerance #174

angelozerr opened this issue Dec 12, 2019 · 3 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@angelozerr
Copy link
Contributor

See https://github.com/eclipse/microprofile-fault-tolerance/blob/master/spec/src/main/asciidoc/configuration.asciidoc

@angelozerr angelozerr self-assigned this Jan 30, 2020
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Feb 3, 2020
@angelozerr
Copy link
Contributor Author

@jclingan I have a question about generation of MP properties for fault tolerance. The documentation says:

The override just changes the value of the corresponding parameter specified in the microservice and nothing more. If no annotation matches the specified parameter, the property will be ignored.

The ignore is for annotation or parameter? Takes a sample, if I have:

package come.acme.test;
public class MyClient{

    @Retry(maxRetries = 90, maxDuration= 1000)
    public void serviceB()

The available properties are:

  • come.acme.test.MyClient/serviceB/Retry/maxRetries
  • come.acme.test.MyClient/serviceB/Retry/maxDuration

But is there other properties for other Retry parameters annotation like:

  • come.acme.test.MyClient/serviceB/Retry/jitter
    ... etc

angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Feb 3, 2020
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Feb 3, 2020
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Feb 4, 2020
@angelozerr
Copy link
Contributor Author

angelozerr commented Feb 4, 2020

@jclingan I start implementing MP Fault Tolerance, here a demo:

MPFTDemo

As you can see I provide all parameters for Retry annotation although the declared Retry annotation in serviceA declares only 2 parameters:

image

@jclingan is it correct?

@angelozerr angelozerr added this to the 1.3.0 milestone Feb 4, 2020
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Feb 4, 2020
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Feb 4, 2020
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Feb 4, 2020
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Feb 4, 2020
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Feb 5, 2020
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Feb 5, 2020
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Feb 5, 2020
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Feb 5, 2020
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Feb 6, 2020
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Feb 6, 2020
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Feb 7, 2020
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Feb 10, 2020
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Feb 11, 2020
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Feb 11, 2020
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Feb 11, 2020
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Feb 11, 2020
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Feb 11, 2020
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Feb 11, 2020
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Feb 11, 2020
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Feb 11, 2020
xorye pushed a commit to redhat-developer/quarkus-ls that referenced this issue Feb 11, 2020
@xorye
Copy link
Contributor

xorye commented Feb 12, 2020

Closed with redhat-developer/quarkus-ls#209

@xorye xorye closed this as completed Feb 12, 2020
@angelozerr angelozerr modified the milestones: 1.3.0, 1.4.0 Feb 14, 2020
@xorye xorye added the enhancement New feature or request label Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants