Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display project name when adding extensions #215

Closed
xorye opened this issue Feb 19, 2020 · 1 comment · Fixed by #270
Closed

Display project name when adding extensions #215

xorye opened this issue Feb 19, 2020 · 1 comment · Fixed by #270
Assignees
@datho7561
Labels
enhancement New feature or request
Milestone
1.6.0

Comments

@xorye
Copy link
Contributor

xorye commented Feb 19, 2020

If there are two Quarkus projects in the workspace: quarkus-project-maven and quarkus-project-maven2, the quickpick after calling Quarkus: Add extension to current Quarkus Project, this quickpick appears:
image

This enhancement idea adds the project name alonsgide the path to pom.xml/build.gradle:
image

To get the project name, maybe we could have the microprofile/java/projectLabels command return not only the project uri, but the project name as well?
@xorye xorye added the enhancement New feature or request label Feb 19, 2020
@xorye xorye mentioned this issue Feb 20, 2020
Merged
@fbricon fbricon added this to the 1.6.0 milestone Jun 24, 2020
@xorye
Copy link
Contributor Author

xorye commented Jun 25, 2020

As mentioned in #204 (comment), currently we have the folder name being displayed instead than the project name

datho7561 added a commit to datho7561/quarkus-ls that referenced this issue Jun 29, 2020
@datho7561
Send project name to the client along with labels.
60a26b1 
This is useful when presenting the different projects in a menu,
such as in redhat-developer/vscode-quarkus#215.

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/vscode-quarkus that referenced this issue Jun 29, 2020
@datho7561
Display project name when adding extensions
1e12f62 
When picking which project to add more extensions to when
you have multiple projects in the same workspace,
the name of the project is now displayed,
instead of just the name of the folder that the project is in.

Fixes redhat-developer#215

Signed-off-by: David Thompson <davthomp@redhat.com>
This was referenced Jun 29, 2020
Merged
Merged
datho7561 added a commit to datho7561/quarkus-ls that referenced this issue Jun 29, 2020
@datho7561
Send project name to the client along with labels.
c5b8fd6 
This is useful when presenting the different projects in a menu,
such as in redhat-developer/vscode-quarkus#215.

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/quarkus-ls that referenced this issue Jun 29, 2020
@datho7561
Send project name to the client along with labels.
5ce6046 
This is useful when presenting the different projects in a menu,
such as in redhat-developer/vscode-quarkus#215.

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/quarkus-ls that referenced this issue Jun 29, 2020
@datho7561
Send project name to the client along with labels.
dd822ab 
This is useful when presenting the different projects in a menu,
such as in redhat-developer/vscode-quarkus#215.

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/quarkus-ls that referenced this issue Jun 30, 2020
@datho7561
Send project name to the client along with labels.
7230fa1 
This is useful when presenting the different projects in a menu,
such as in redhat-developer/vscode-quarkus#215.

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/quarkus-ls that referenced this issue Jun 30, 2020
@datho7561
Send project name to the client along with labels.
b101ed4 
This is useful when presenting the different projects in a menu,
such as in redhat-developer/vscode-quarkus#215.

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/quarkus-ls that referenced this issue Jun 30, 2020
@datho7561
Send project name to the client along with labels.
5e88cac 
This is useful when presenting the different projects in a menu,
such as in redhat-developer/vscode-quarkus#215.

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/quarkus-ls that referenced this issue Jun 30, 2020
@datho7561
Send project name to the client along with labels.
6b001d9 
This is useful when presenting the different projects in a menu,
such as in redhat-developer/vscode-quarkus#215.

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/quarkus-ls that referenced this issue Jul 2, 2020
@datho7561
Send project name to the client along with labels.
e954000 
This is useful when presenting the different projects in a menu,
such as in redhat-developer/vscode-quarkus#215.

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/quarkus-ls that referenced this issue Jul 2, 2020
@datho7561
Send project name to the client along with labels.
1a60ddb 
This is useful when presenting the different projects in a menu,
such as in redhat-developer/vscode-quarkus#215.

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/quarkus-ls that referenced this issue Jul 2, 2020
@datho7561
Send project name to the client along with labels.
5aadc29 
This is useful when presenting the different projects in a menu,
such as in redhat-developer/vscode-quarkus#215.

Signed-off-by: David Thompson <davthomp@redhat.com>
fbricon pushed a commit to redhat-developer/quarkus-ls that referenced this issue Jul 7, 2020
@datho7561
Send project name to the client along with labels. (#330)
399f30b 
This is useful when presenting the different projects in a menu,
such as in redhat-developer/vscode-quarkus#215.

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/vscode-quarkus that referenced this issue Jul 7, 2020
@datho7561
Display project name when adding extensions
9f1996f 
When picking which project to add more extensions to when
you have multiple projects in the same workspace,
the name of the project is now displayed,
instead of just the name of the folder that the project is in.

Fixes redhat-developer#215

Signed-off-by: David Thompson <davthomp@redhat.com>
@xorye xorye closed this as completed in #270 Jul 9, 2020
xorye pushed a commit that referenced this issue Jul 9, 2020
@datho7561 @xorye
Display project name when adding extensions
3c13d94 
When picking which project to add more extensions to when
you have multiple projects in the same workspace,
the name of the project is now displayed,
instead of just the name of the folder that the project is in.

Fixes #215

Signed-off-by: David Thompson <davthomp@redhat.com>
@xorye xorye changed the title Improve add extensions quickpick when multiple Quarkus projects exist in current workspace Display project name when adding extensions Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@datho7561 datho7561

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.6.0
Development

Successfully merging a pull request may close this issue.

Display project name when adding extensions datho7561/vscode-quarkus
3 participants
@fbricon @xorye @datho7561