Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notification when the quarkus.tools.propertiesLanguageMismatch setting is set to forceQuarkus #285

Closed
xorye opened this issue Jul 14, 2020 · 0 comments · Fixed by #295
Closed

Notification when the quarkus.tools.propertiesLanguageMismatch setting is set to forceQuarkus #285

xorye opened this issue Jul 14, 2020 · 0 comments · Fixed by #295
Assignees
@datho7561
Labels
enhancement New feature or request
Milestone
1.7.0

Comments

@xorye
Copy link
Contributor

xorye commented Jul 14, 2020

When quarkus.tools.propertiesLanguageMismatch = forceQuarkus, it would be great if there is a notification to the user if the user tries to set the languageId of an application.properties file from Quarkus Properties to something else.

Something along the lines of:

Quarkus Tools for Visual Studio Code requires this file's language to be 'Quarkus Properties'
for language support. Edit settings to configure.

[Configure]

with a button ([Configure]) that takes the user to quarkus.tools.propertiesLanguageMismatch in the settings UI.
@xorye xorye added the enhancement New feature or request label Jul 14, 2020
@fbricon fbricon added this to the 1.7.0 milestone Jul 16, 2020
@fbricon fbricon assigned datho7561 and unassigned xorye Jul 16, 2020
datho7561 added a commit to datho7561/vscode-quarkus that referenced this issue Jul 20, 2020
@datho7561
Notification when languageID is forced
ca153f6 
Provides a notification when the user tries to switch the language ID
of the properties file, and provides a 'Configure' button that navigates
to the `quarkus.tools.propertiesLanguageMismatch` setting.
Closes redhat-developer#285

Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561 datho7561 mentioned this issue Jul 20, 2020
Merged
datho7561 added a commit to datho7561/vscode-quarkus that referenced this issue Jul 20, 2020
@datho7561
Notification when languageID is forced
76f41f8 
Provides a notification when the user tries to switch the language ID
of the properties file, and provides a 'Configure' button that navigates
to the `quarkus.tools.propertiesLanguageMismatch` setting.
Closes redhat-developer#285

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/vscode-quarkus that referenced this issue Jul 21, 2020
@datho7561
Notification when languageID is forced
54e8129 
Provides a notification when the user tries to switch the language ID
of the properties file, and provides a 'Configure' button that navigates
to the `quarkus.tools.propertiesLanguageMismatch` setting.
Closes redhat-developer#285

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/vscode-quarkus that referenced this issue Jul 22, 2020
@datho7561
Notification when languageID is forced
7aa0d97 
Provides a notification when the user tries to switch the language ID
of the properties file, and provides a 'Configure' button that navigates
to the `quarkus.tools.propertiesLanguageMismatch` setting.
Closes redhat-developer#285

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/vscode-quarkus that referenced this issue Jul 22, 2020
@datho7561
Notification when languageID is forced
50663a8 
Provides a notification when the user tries to switch the language ID
of the properties file, and provides a 'Configure' button that navigates
to the `quarkus.tools.propertiesLanguageMismatch` setting.
Closes redhat-developer#285

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/vscode-quarkus that referenced this issue Jul 23, 2020
@datho7561
Notification when languageID is forced
e5dfe00 
Provides a notification when the user tries to switch the language ID
of the properties file, and provides a 'Configure' button that navigates
to the `quarkus.tools.propertiesLanguageMismatch` setting.
Closes redhat-developer#285

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/vscode-quarkus that referenced this issue Aug 11, 2020
@datho7561
Notification when languageID is forced
64b73e1 
Provides a notification when the user tries to switch the language ID
of the properties file, and provides a 'Configure' button that navigates
to the `quarkus.tools.propertiesLanguageMismatch` setting.
Closes redhat-developer#285

Signed-off-by: David Thompson <davthomp@redhat.com>
angelozerr pushed a commit that referenced this issue Sep 11, 2020
@datho7561 @angelozerr
Notification when languageID is forced
d8a455e 
Provides a notification when the user tries to switch the language ID
of the properties file, and provides a 'Configure' button that navigates
to the `quarkus.tools.propertiesLanguageMismatch` setting.
Closes #285

Signed-off-by: David Thompson <davthomp@redhat.com>
@angelozerr angelozerr changed the title Notification when propertiesLanguageMismatch is forceQuarkus and user tries to set languageId to something else Notification when the quarkus.tools.propertiesLanguageMismatch setting is set to forceQuarkus Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@datho7561 datho7561

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.7.0
Development

Successfully merging a pull request may close this issue.

Notification when languageID is forced datho7561/vscode-quarkus
3 participants
@fbricon @xorye @datho7561