Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate why quarkus-properties appears twice when registering textDocument/rangeFormatting #296

Closed
xorye opened this issue Jul 28, 2020 · 1 comment · Fixed by eclipse/lsp4mp#52
Assignees
Labels
bug Something isn't working
Milestone

Comments

@xorye
Copy link
Contributor

xorye commented Jul 28, 2020

In the 1.6.0 release (before the vscode-microprofile / vscode-quarkus split), when opening a Quarkus application.properites file,
looking at the server trace, quarkus-properties appears twice in the client/registerCapability request for range formatting;

[Trace - 11:16:26 a.m.] Received request 'client/registerCapability - (8)'.
Params: {
    "registrations": [
        {
            "id": "61e7b5ba-a567-4415-8817-70e18fed36a9",
            "method": "textDocument/rangeFormatting",
            "registerOptions": {
                "documentSelector": [
                    {
                        "language": "microprofile-properties"
                    },
                    {
                        "language": "quarkus-properties"
                    },
                    {
                        "language": "quarkus-properties"
                    }
                ]
            }
        }
    ]
}

It's strange that quarkus-properties appears twice, although I couldn't find any bugs because of this. Range formatting still works as expected.

@datho7561
Copy link
Contributor

This line here in quarkus-ls is likely contributing the extra occurrence of quarkus-properties.

@fbricon fbricon added this to the 1.7.0 milestone Aug 11, 2020
@angelozerr angelozerr added the bug Something isn't working label Aug 12, 2020
angelozerr pushed a commit to angelozerr/lsp4mp that referenced this issue Aug 12, 2020
`textDocument/rangeFormatting`

See redhat-developer/vscode-quarkus#296

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to angelozerr/lsp4mp that referenced this issue Aug 12, 2020
`textDocument/rangeFormatting`

Fixes redhat-developer/vscode-quarkus#296

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to angelozerr/lsp4mp that referenced this issue Aug 12, 2020
`textDocument/rangeFormatting`

Fixes redhat-developer/vscode-quarkus#296

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to eclipse/lsp4mp that referenced this issue Aug 28, 2020
`textDocument/rangeFormatting`

Fixes redhat-developer/vscode-quarkus#296

Signed-off-by: azerr <azerr@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants