Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quarkus.hibernate-orm.database.generation values should be enumerated #317

Closed
fbricon opened this issue Nov 1, 2020 · 3 comments · Fixed by redhat-developer/quarkus-ls#374
Closed

quarkus.hibernate-orm.database.generation values should be enumerated #317

fbricon opened this issue Nov 1, 2020 · 3 comments · Fixed by redhat-developer/quarkus-ls#374
Assignees
@rgrunber
Labels
enhancement New feature or request
Milestone
1.8.0

Comments

@fbricon
Copy link
Collaborator

fbricon commented Nov 1, 2020 •
edited

Currently quarkus.hibernate-orm.database.generation provides no completion for its possible values. We should see none, create, drop-and-create, drop, update.

Screenshot 2020-11-01 at 18 17 27

You can see an example in https://github.com/fbricon/quarkus-spread-poll/blob/master/src/main/resources/application.properties#L19
@fbricon fbricon added the enhancement New feature or request label Nov 1, 2020
@angelozerr
Copy link
Contributor

To fix this issue, we should declare on quarkus-ls an hints for this property like https://github.com/eclipse/lsp4mp/blob/ab86a54e2be98c20ada1664ce910a015779c6b4d/microprofile.jdt/org.eclipse.lsp4mp.jdt.core/static-properties/mp-opentracing-metadata.json#L31

@angelozerr
Copy link
Contributor

Like Spring Boot does https://github.com/spring-projects/spring-boot/blob/a8705d19e59c6ab0a8555c079e59995aad395210/spring-boot-project/spring-boot-autoconfigure/src/main/resources/META-INF/additional-spring-configuration-metadata.json#L1871

@angelozerr
Copy link
Contributor

This issue should be very easy to do.

@rgrunber rgrunber self-assigned this Nov 19, 2020
@angelozerr angelozerr added this to the 1.8.0 milestone Nov 20, 2020
rgrunber added a commit to rgrunber/quarkus-ls that referenced this issue Dec 4, 2020
@rgrunber
quarkus.hibernate-orm.database.generation values should be enumerated.
06e0ae9 
- Fixes redhat-developer/vscode-quarkus#317

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
@rgrunber rgrunber mentioned this issue Dec 4, 2020
Merged
rgrunber added a commit to rgrunber/quarkus-ls that referenced this issue Dec 7, 2020
@rgrunber
quarkus.hibernate-orm.database.generation values should be enumerated.
fc356e8 
- Fixes redhat-developer/vscode-quarkus#317
- Add testcase

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
angelozerr pushed a commit to redhat-developer/quarkus-ls that referenced this issue Dec 9, 2020
@rgrunber @angelozerr
quarkus.hibernate-orm.database.generation values should be enumerated.
497c13f 
- Fixes redhat-developer/vscode-quarkus#317
- Add testcase

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rgrunber rgrunber

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.8.0
Development

Successfully merging a pull request may close this issue.

quarkus.hibernate-orm.database.generation values should be enumerated. rgrunber/quarkus-ls
3 participants
@fbricon @rgrunber @angelozerr