Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'RESTEasy JAX-RS' should no longer be added by default #322

Closed
fbricon opened this issue Nov 20, 2020 · 11 comments · Fixed by #329
Closed

'RESTEasy JAX-RS' should no longer be added by default #322

fbricon opened this issue Nov 20, 2020 · 11 comments · Fixed by #329
Assignees
Labels
enhancement New feature or request wizards
Milestone

Comments

@fbricon
Copy link
Collaborator

fbricon commented Nov 20, 2020

https://code.quarkus.io/ no longer adds 'RESTEasy JAX-RS' by default, so the new project wizard should do the same

@fbricon fbricon added the enhancement New feature or request label Nov 20, 2020
@fbricon
Copy link
Collaborator Author

fbricon commented Nov 20, 2020

It's not that trivial since https://code.quarkus.redhat.com/api is behind https://code.quarkus.io/api, and still includes it by default.

@ia3andy any way to detect whether we should flag 'RESTEasy JAX-RS' as included?

@ia3andy
Copy link

ia3andy commented Nov 20, 2020

@fbricon yes, on https://code.quarkus.redhat.com/api/extensions it has the default flag to true, and to false on https://code.quarkus.io/api/extensions

@fbricon fbricon added this to the 1.8.0 milestone Nov 20, 2020
@datho7561
Copy link
Contributor

datho7561 commented Dec 9, 2020

Sorry, just looking at this now. If I use the default options through the web UI at code.quarkus.io, or specify 0 extensions when querying the rest API, I still get this in the pom.xml:

...
<dependency>
  <groupId>io.quarkus</groupId>
  <artifactId>quarkus-resteasy</artifactId>
</dependency>
...

Is RESTEasy JAX-RS separate from quarkus-resteasy? Is RESTEasy JAX-RS is automatically added unless some other component is added? If so, which component do I need to add to prevent RESTEasy JAX-RS from being automatically added?

@ia3andy
Copy link

ia3andy commented Dec 14, 2020

@datho7561 if you don't pick any other example, then the quarkus-resteasy example is added.

If you don't want any example, you need to add an extension with anouther example (ex: quarkus-qute) or to add &ne=trye which stand for no examples.

@datho7561
Copy link
Contributor

@fbricon We could add another step to the wizard to specify if quickstart code should be generated, and add a warning that adding quickstart code may pull in other dependencies. Do you think this would be a good solution?

datho7561 added a commit to datho7561/vscode-quarkus that referenced this issue Jan 22, 2021
Reads the data from code.quarkus.io or code.quarkus.redhat.com to see
which quarkus extensions are required.
This means if code.quarkus.io is used, then resteasy is not required.
Adds another step to the project generation wizard to specify if sample
code should be generated.

Closes redhat-developer#322

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/vscode-quarkus that referenced this issue Jan 22, 2021
Reads the data from code.quarkus.io or code.quarkus.redhat.com to see
which quarkus extensions are required.
This means if code.quarkus.io is used, then resteasy is not required.
Adds another step to the project generation wizard to specify if sample
code should be generated.

Closes redhat-developer#322

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/vscode-quarkus that referenced this issue Mar 5, 2021
Reads the data from code.quarkus.io or code.quarkus.redhat.com
to see which quarkus extensions are required.
This means if code.quarkus.io is used, then resteasy is not required.
Reads the Open API of the code quarkus instance to determine if
the option to prevent sample code being generated is present.
If it is, then it adds another step to the project
generation wizard to specify if sample code should be generated.

Closes redhat-developer#322

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/vscode-quarkus that referenced this issue Mar 5, 2021
Reads the data from code.quarkus.io or code.quarkus.redhat.com
to see which quarkus extensions are required.
This means if code.quarkus.io is used, then resteasy is not required.
Reads the Open API of the code quarkus instance to determine if
the option to prevent sample code being generated is present.
If it is, then it adds another step to the project
generation wizard to specify if sample code should be generated.

Closes redhat-developer#322

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/vscode-quarkus that referenced this issue Mar 5, 2021
Reads the data from code.quarkus.io or code.quarkus.redhat.com
to see which quarkus extensions are required.
This means if code.quarkus.io is used, then resteasy is not required.
Reads the Open API of the code quarkus instance to determine if
the option to prevent sample code being generated is present.
If it is, then it adds another step to the project
generation wizard to specify if sample code should be generated.

Closes redhat-developer#322

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/vscode-quarkus that referenced this issue Mar 5, 2021
Reads the data from code.quarkus.io or code.quarkus.redhat.com
to see which quarkus extensions are required.
This means if code.quarkus.io is used, then resteasy is not required.
Reads the Open API of the code quarkus instance to determine if
the option to prevent sample code being generated is present.
If it is, then it adds another step to the project
generation wizard to specify if sample code should be generated.

Closes redhat-developer#322

Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561 datho7561 modified the milestones: 1.8.0, 1.9.0 Apr 13, 2021
datho7561 added a commit to datho7561/vscode-quarkus that referenced this issue May 12, 2021
Reads the data from code.quarkus.io or code.quarkus.redhat.com
to see which quarkus extensions are required.
This means if code.quarkus.io is used, then resteasy is not required.
Reads the Open API of the code quarkus instance to determine if
the option to prevent sample code being generated is present.
If it is, then it adds another step to the project
generation wizard to specify if sample code should be generated.

Closes redhat-developer#322

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/vscode-quarkus that referenced this issue May 12, 2021
Reads the data from code.quarkus.io or code.quarkus.redhat.com
to see which quarkus extensions are required.
This means if code.quarkus.io is used, then resteasy is not required.
Reads the Open API of the code quarkus instance to determine if
the option to prevent sample code being generated is present.
If it is, then it adds another step to the project
generation wizard to specify if sample code should be generated.

Closes redhat-developer#322

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/vscode-quarkus that referenced this issue May 12, 2021
Reads the data from code.quarkus.io or code.quarkus.redhat.com
to see which quarkus extensions are required.
This means if code.quarkus.io is used, then resteasy is not required.
Reads the Open API of the code quarkus instance to determine if
the option to prevent sample code being generated is present.
If it is, then it adds another step to the project
generation wizard to specify if sample code should be generated.

Closes redhat-developer#322

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/vscode-quarkus that referenced this issue May 13, 2021
Reads the data from code.quarkus.io or code.quarkus.redhat.com
to see which quarkus extensions are required.
This means if code.quarkus.io is used, then resteasy is not required.
Reads the Open API of the code quarkus instance to determine if
the option to prevent sample code being generated is present.
If it is, then it adds another step to the project
generation wizard to specify if sample code should be generated.

Closes redhat-developer#322

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/vscode-quarkus that referenced this issue May 13, 2021
Reads the data from code.quarkus.io or code.quarkus.redhat.com
to see which quarkus extensions are required.
This means if code.quarkus.io is used, then resteasy is not required.
Reads the Open API of the code quarkus instance to determine if
the option to prevent sample code being generated is present.
If it is, then it adds another step to the project
generation wizard to specify if sample code should be generated.

Closes redhat-developer#322

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/vscode-quarkus that referenced this issue May 13, 2021
Reads the data from code.quarkus.io or code.quarkus.redhat.com
to see which quarkus extensions are required.
This means if code.quarkus.io is used, then resteasy is not required.
Reads the Open API of the code quarkus instance to determine if
the option to prevent sample code being generated is present.
If it is, then it adds another step to the project
generation wizard to specify if sample code should be generated.

Closes redhat-developer#322

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/vscode-quarkus that referenced this issue May 13, 2021
Reads the data from code.quarkus.io or code.quarkus.redhat.com
to see which quarkus extensions are required.
This means if code.quarkus.io is used, then resteasy is not required.
Reads the Open API of the code quarkus instance to determine if
the option to prevent sample code being generated is present.
If it is, then it adds another step to the project
generation wizard to specify if sample code should be generated.

Closes redhat-developer#322

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/vscode-quarkus that referenced this issue May 13, 2021
Reads the data from code.quarkus.io or code.quarkus.redhat.com
to see which quarkus extensions are required.
This means if code.quarkus.io is used, then resteasy is not required.
Reads the Open API of the code quarkus instance to determine if
the option to prevent sample code being generated is present.
If it is, then it adds another step to the project
generation wizard to specify if sample code should be generated.

Closes redhat-developer#322

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/vscode-quarkus that referenced this issue May 13, 2021
Reads the data from code.quarkus.io or code.quarkus.redhat.com
to see which quarkus extensions are required.
This means if code.quarkus.io is used, then resteasy is not required.
Reads the Open API of the code quarkus instance to determine if
the option to prevent sample code being generated is present.
If it is, then it adds another step to the project
generation wizard to specify if sample code should be generated.

Closes redhat-developer#322

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/vscode-quarkus that referenced this issue May 13, 2021
Reads the data from code.quarkus.io or code.quarkus.redhat.com
to see which quarkus extensions are required.
This means if code.quarkus.io is used, then resteasy is not required.
Reads the Open API of the code quarkus instance to determine if
the option to prevent sample code being generated is present.
If it is, then it adds another step to the project
generation wizard to specify if sample code should be generated.

Closes redhat-developer#322

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/vscode-quarkus that referenced this issue Jun 16, 2021
Reads the data from code.quarkus.io or code.quarkus.redhat.com
to see which quarkus extensions are required.
This means if code.quarkus.io is used, then resteasy is not required.
Reads the Open API of the code quarkus instance to determine if
the option to prevent sample code being generated is present.
If it is, then it adds another step to the project
generation wizard to specify if sample code should be generated.

Closes redhat-developer#322

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/vscode-quarkus that referenced this issue Jun 16, 2021
Reads the data from code.quarkus.io or code.quarkus.redhat.com
to see which quarkus extensions are required.
This means if code.quarkus.io is used, then resteasy is not required.
Reads the Open API of the code quarkus instance to determine if
the option to prevent sample code being generated is present.
If it is, then it adds another step to the project
generation wizard to specify if sample code should be generated.

Closes redhat-developer#322

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/vscode-quarkus that referenced this issue Jul 22, 2021
Reads the data from code.quarkus.io or code.quarkus.redhat.com
to see which quarkus extensions are required.
This means if code.quarkus.io is used, then resteasy is not required.
Reads the Open API of the code quarkus instance to determine if
the option to prevent sample code being generated is present.
If it is, then it adds another step to the project
generation wizard to specify if sample code should be generated.

Closes redhat-developer#322

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/vscode-quarkus that referenced this issue Jul 22, 2021
Reads the data from code.quarkus.io or code.quarkus.redhat.com
to see which quarkus extensions are required.
This means if code.quarkus.io is used, then resteasy is not required.
Reads the Open API of the code quarkus instance to determine if
the option to prevent sample code being generated is present.
If it is, then it adds another step to the project
generation wizard to specify if sample code should be generated.

Closes redhat-developer#322

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/vscode-quarkus that referenced this issue Jul 22, 2021
Reads the data from code.quarkus.io or code.quarkus.redhat.com
to see which quarkus extensions are required.
This means if code.quarkus.io is used, then resteasy is not required.
Reads the Open API of the code quarkus instance to determine if
the option to prevent sample code being generated is present.
If it is, then it adds another step to the project
generation wizard to specify if sample code should be generated.

Closes redhat-developer#322

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/vscode-quarkus that referenced this issue Jul 22, 2021
Reads the data from code.quarkus.io or code.quarkus.redhat.com
to see which quarkus extensions are required.
This means if code.quarkus.io is used, then resteasy is not required.
Reads the Open API of the code quarkus instance to determine if
the option to prevent sample code being generated is present.
If it is, then it adds another step to the project
generation wizard to specify if sample code should be generated.

Closes redhat-developer#322

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/vscode-quarkus that referenced this issue Jul 23, 2021
Reads the data from code.quarkus.io or code.quarkus.redhat.com
to see which quarkus extensions are required.
This means if code.quarkus.io is used, then resteasy is not required.
Reads the Open API of the code quarkus instance to determine if
the option to prevent sample code being generated is present.
If it is, then it adds another step to the project
generation wizard to specify if sample code should be generated.

Closes redhat-developer#322

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/vscode-quarkus that referenced this issue Jul 23, 2021
Reads the data from code.quarkus.io or code.quarkus.redhat.com
to see which quarkus extensions are required.
This means if code.quarkus.io is used, then resteasy is not required.
Reads the Open API of the code quarkus instance to determine if
the option to prevent sample code being generated is present.
If it is, then it adds another step to the project
generation wizard to specify if sample code should be generated.

Closes redhat-developer#322

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/vscode-quarkus that referenced this issue Jul 26, 2021
Reads the data from code.quarkus.io or code.quarkus.redhat.com
to see which quarkus extensions are required.
This means if code.quarkus.io is used, then resteasy is not required.
Reads the Open API of the code quarkus instance to determine if
the option to prevent sample code being generated is present.
If it is, then it adds another step to the project
generation wizard to specify if sample code should be generated.

Closes redhat-developer#322

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/vscode-quarkus that referenced this issue Jul 27, 2021
Reads the data from code.quarkus.io or code.quarkus.redhat.com
to see which quarkus extensions are required.
This means if code.quarkus.io is used, then resteasy is not required.
Reads the Open API of the code quarkus instance to determine if
the option to prevent sample code being generated is present.
If it is, then it adds another step to the project
generation wizard to specify if sample code should be generated.

Closes redhat-developer#322

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/vscode-quarkus that referenced this issue Jul 27, 2021
Reads the data from code.quarkus.io or code.quarkus.redhat.com
to see which quarkus extensions are required.
This means if code.quarkus.io is used, then resteasy is not required.
Reads the Open API of the code quarkus instance to determine if
the option to prevent sample code being generated is present.
If it is, then it adds another step to the project
generation wizard to specify if sample code should be generated.

Closes redhat-developer#322

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/vscode-quarkus that referenced this issue Jul 27, 2021
Reads the data from code.quarkus.io or code.quarkus.redhat.com
to see which quarkus extensions are required.
This means if code.quarkus.io is used, then resteasy is not required.
Reads the Open API of the code quarkus instance to determine if
the option to prevent sample code being generated is present.
If it is, then it adds another step to the project
generation wizard to specify if sample code should be generated.

Closes redhat-developer#322

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit that referenced this issue Jul 27, 2021
Reads the data from code.quarkus.io or code.quarkus.redhat.com
to see which quarkus extensions are required.
This means if code.quarkus.io is used, then resteasy is not required.
Reads the Open API of the code quarkus instance to determine if
the option to prevent sample code being generated is present.
If it is, then it adds another step to the project
generation wizard to specify if sample code should be generated.

Closes #322

Signed-off-by: David Thompson <davthomp@redhat.com>
@ia3andy
Copy link

ia3andy commented Jul 28, 2021

Hi @datho7561 ,

The api has changed since the discussion started, the parameter to use is nc ("No Code"), ne has been deprecated, the text to use in the wizard would be:
"Decide whether to include the starter code provided by extensions or get an empty Quarkus project."
If the answer is "Yes" then nc=false
If the answer is "No" then nc=true

It would be nice to update this before it gets to delivered to the user.

The reason behind this is that we don't deliver sample code anymore but starter code, the nuance is subtile (starter code is meant to start your app while sample/example code is meant to learn and be deleted)

Let me know if you have any question :)

Cheers

@fbricon
Copy link
Collaborator Author

fbricon commented Jul 28, 2021

"Decide whether to include the starter code provided by extensions or get an empty Quarkus project." is not a yes-no question ;-)

@ia3andy
Copy link

ia3andy commented Jul 28, 2021

@fbricon Sorry I wasn't precise enough :)
image

@ia3andy
Copy link

ia3andy commented Jul 28, 2021

I am currently working on showing deprecated fields in https://code.quarkus.io/q/swagger-ui

@datho7561
Copy link
Contributor

@ia3andy Going to fix this before the next release. How long are you planning on supporting the deprecated ne parameter?

@ia3andy
Copy link

ia3andy commented Jul 28, 2021

@datho7561 it will not break even if kept, just it will include the code whatever its value when I remove the support. I don't have any specific date yet.

datho7561 added a commit to datho7561/vscode-quarkus that referenced this issue Jul 28, 2021
Checks the Code Quarkus openapi for the `nc` parameter.
If it is available for the given Code Quarkus API,
then it will pass `nc=true` to the project generation API
when the user wants to exclude example code,
instead of the deprecated `ne=true` parameter.

Addresses comments on redhat-developer#322

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/vscode-quarkus that referenced this issue Jul 28, 2021
Checks the Code Quarkus openapi for the `nc` parameter.
If it is available for the given Code Quarkus API,
then it will pass `nc=true` to the project generation API
when the user wants to exclude example code,
instead of the deprecated `ne=true` parameter.

Addresses comments on redhat-developer#322

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/vscode-quarkus that referenced this issue Jul 28, 2021
Checks the Code Quarkus openapi for the `nc` parameter.
If it is available for the given Code Quarkus API,
then it will pass `nc=true` to the project generation API
when the user wants to exclude example code,
instead of the deprecated `ne=true` parameter.

Addresses comments on redhat-developer#322

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/vscode-quarkus that referenced this issue Jul 28, 2021
Checks the Code Quarkus openapi for the `nc` parameter.
If it is available for the given Code Quarkus API,
then it will pass `nc=true` to the project generation API
when the user wants to exclude example code,
instead of the deprecated `ne=true` parameter.

Addresses comments on redhat-developer#322

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit that referenced this issue Jul 28, 2021
Checks the Code Quarkus openapi for the `nc` parameter.
If it is available for the given Code Quarkus API,
then it will pass `nc=true` to the project generation API
when the user wants to exclude example code,
instead of the deprecated `ne=true` parameter.

Addresses comments on #322

Signed-off-by: David Thompson <davthomp@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wizards
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants