Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update @redhat-developer/vscode-redhat-telemetry to 0.1.1 #365

Closed
datho7561 opened this issue Jun 8, 2021 · 1 comment · Fixed by #369
Closed

Update @redhat-developer/vscode-redhat-telemetry to 0.1.1 #365

datho7561 opened this issue Jun 8, 2021 · 1 comment · Fixed by #369
Assignees
@datho7561
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Milestone
1.9.0

Comments

@datho7561
Copy link
Contributor

datho7561 commented Jun 8, 2021 •
edited

This removes the dependency to vscode-commons.

See https://github.com/redhat-developer/vscode-redhat-telemetry#add-the-below-code-to-your-extensionts for instructions on how to implement this change.

Note that redhat.telemetry.enabled doesn't need to be added to the package.json, since it will be contributed by vscode-java see note from Fred
@datho7561 datho7561 added enhancement New feature or request dependencies Pull requests that update a dependency file labels Jun 8, 2021
@fbricon
Copy link
Collaborator

fbricon commented Jun 8, 2021

not until java telemetry is rolled out. Until then vscode-microprofile should own it

@datho7561 datho7561 mentioned this issue Jun 8, 2021
Closed
datho7561 added a commit to datho7561/vscode-quarkus that referenced this issue Jun 23, 2021
@datho7561
Update @redhat-developer/vscode-redhat-telemetry to 0.2.0
56e8601 
Closes redhat-developer#365

Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561 datho7561 mentioned this issue Jun 23, 2021
Merged
datho7561 added a commit to datho7561/vscode-quarkus that referenced this issue Jul 22, 2021
@datho7561
Update @redhat-developer/vscode-redhat-telemetry to 0.2.0
a0bc65d 
Closes redhat-developer#365

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/vscode-quarkus that referenced this issue Jul 23, 2021
@datho7561
Update @redhat-developer/vscode-redhat-telemetry to 0.2.0
07b3bc2 
Closes redhat-developer#365

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/vscode-quarkus that referenced this issue Jul 23, 2021
@datho7561
Update @redhat-developer/vscode-redhat-telemetry to 0.2.0
7517a12 
Closes redhat-developer#365

Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561 datho7561 self-assigned this Jul 23, 2021
@datho7561 datho7561 added this to the 1.9.0 milestone Jul 23, 2021
datho7561 added a commit that referenced this issue Jul 23, 2021
@datho7561
Update @redhat-developer/vscode-redhat-telemetry to 0.2.0
2636c37 
Closes #365

Signed-off-by: David Thompson <davthomp@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@datho7561 datho7561

Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Milestone
1.9.0
Development

Successfully merging a pull request may close this issue.

Update @redhat-developer/vscode-redhat-telemetry to 0.2.0 datho7561/vscode-quarkus
2 participants
@fbricon @datho7561