Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugging no-starter code projects fails #389

Closed
fbricon opened this issue Aug 30, 2021 · 1 comment · Fixed by #390
Closed

Debugging no-starter code projects fails #389

fbricon opened this issue Aug 30, 2021 · 1 comment · Fixed by #390
Labels
bug Something isn't working
Milestone

Comments

@fbricon
Copy link
Collaborator

fbricon commented Aug 30, 2021

When creating a no-starter code project (you still need to create 1 java file), if you execute the debug quarkus command, the process never completes.
This is mostly caused by the quarkus dev task's problemMatcher.background.endspattern value, that expects a "listening on" pattern.

taskEndsPattern: '^.*Quarkus .* started in .*\\. Listening on:*'

taskEndsPattern: '^.*Quarkus .* started in .*\\. Listening on:*'

When no http server is started, that last sentence is missing, it then just waits indefinitely.

Using ^.*Quarkus .* started in .*\\.* works.

Also, it doesn't seem to cause an issue but when a Gradle deamon is reused, this pattern is never found:

taskBeginsPattern: '^.*Starting a Gradle Daemon*',

I'd simply use Task : instead

@fbricon fbricon added the bug Something isn't working label Aug 30, 2021
@rgrunber
Copy link
Member

Yup, I can reproduce :

2021-08-30 12:46:46,325 INFO [io.quarkus] (Quarkus Main Thread) quarkus-no-code 1.0.0-SNAPSHOT on JVM (powered by Quarkus 2.1.4.Final) started in 1.290s.

rgrunber added a commit to rgrunber/vscode-quarkus that referenced this issue Aug 30, 2021
- Adjust task pattern to recognize build output when no starter code is
  present
- Fixes redhat-developer#389

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
rgrunber added a commit to rgrunber/vscode-quarkus that referenced this issue Aug 31, 2021
- Adjust task pattern to recognize build output when no starter code is
  present
- Fixes redhat-developer#389

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
rgrunber added a commit to rgrunber/vscode-quarkus that referenced this issue Aug 31, 2021
- Adjust task pattern to recognize build output when no starter code is
  present
- Add pattern to detect task has ended on failed launch
- Fixes redhat-developer#389

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
rgrunber added a commit to rgrunber/vscode-quarkus that referenced this issue Sep 1, 2021
- Adjust task pattern to recognize build output when no starter code is
  present
- Add pattern to detect task has ended on failed launch
- Fixes redhat-developer#389

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
rgrunber added a commit that referenced this issue Sep 1, 2021
- Adjust task pattern to recognize build output when no starter code is
  present
- Add pattern to detect task has ended on failed launch
- Fixes #389

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
@rgrunber rgrunber added this to the 1.9.1 milestone Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants