Quarkus API URL should use https

[fbricon]

vscode-quarkus/package.json

Line 173 in 734f46a

"default": "http://code.quarkus.io/api",

[angelozerr]

@fbricon it seems code replace http with https

vscode-quarkus/src/utils/codeQuarkusApiUtils.ts

Line 95 in 734f46a

const platformApiRes = await httpsGet((QuarkusConfig.getApiUrl() + '/streams').replace(HTTP_MATCHER, "https://"));

[fbricon]

that's a hack! Shouldn't happen in the first place. You wouldn't be able to run against the quarkus api server running locally on a non https server.

[fbricon]

and it's only for getting the list of streams. Other places still use the package.json value

[rgrunber]

Yup, I've noticed this. We have an http value in package.json which can be overriden by another default when it's parsed, and then we adjust that again with a regex/replace match. Seems we can remove those replacements by just using https everywhere.

[fbricon]

Don't assume https. https on production is a given, but running against a locally running api server means probably http.

[rgrunber]

Don't assume https. https on production is a given, but running against a locally running api server means probably http.

Whoops, I meant just our default values for https://github.com/redhat-developer/vscode-quarkus/blob/master/package.json#L173 & https://github.com/redhat-developer/vscode-quarkus/blob/master/src/definitions/constants.ts#L39 should be https if not already and we should avoid doing replacements on a user-defined value.