Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the "Deploy to OpenShift" command more discoverable #406

Closed
fbricon opened this issue Oct 20, 2021 · 3 comments · Fixed by #409
Closed

Make the "Deploy to OpenShift" command more discoverable #406

fbricon opened this issue Oct 20, 2021 · 3 comments · Fixed by #409
Assignees
@rgrunber
Labels
enhancement New feature or request
Milestone
1.10.0

Comments

@fbricon
Copy link
Collaborator

fbricon commented Oct 20, 2021

Today, only people who know the "Deploy to OpenShift" command exist will be able to use it. We need to figure out a way to make it more obvious
@fbricon fbricon added the enhancement New feature or request label Oct 20, 2021
@rgrunber rgrunber self-assigned this Oct 20, 2021
@rgrunber
Copy link
Member

rgrunber commented Oct 21, 2021 •
edited

Currently, we only generate a notification when a user debugs a Quarkus application, and only the first time, so very limited.

A few places we could put this :

rgrunber added a commit to rgrunber/vscode-quarkus that referenced this issue Oct 25, 2021
@rgrunber
Make "Deploy to OpenShift" command more discoverable
f024495 
- Fixes redhat-developer#406

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
@rgrunber rgrunber mentioned this issue Oct 25, 2021
Merged
rgrunber added a commit to rgrunber/vscode-quarkus that referenced this issue Oct 26, 2021
@rgrunber
Make "Deploy to OpenShift" command more discoverable
af7edd2 
- Add command to editor title menu bar
- Add command to the view title menu
- Fixes redhat-developer#406

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
rgrunber added a commit to rgrunber/vscode-quarkus that referenced this issue Oct 26, 2021
@rgrunber
Make "Deploy to OpenShift" command more discoverable
a4bd16c 
- Add command to editor title menu bar, and view title menu
- Also make "Debug Quarkus Application" more discoverable by adding to
  title run menu
- Create a duplicate command, ${id}.short whose title is a shorter
  version suitable for context menus
- Fixes redhat-developer#406

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
@rgrunber rgrunber added this to the 1.9.1 milestone Nov 1, 2021
rgrunber added a commit that referenced this issue Nov 2, 2021
@rgrunber
Make "Deploy to OpenShift" command more discoverable
75bbc34 
- Add command to editor title menu bar, and view title menu
- Also make "Debug Quarkus Application" more discoverable by adding to
  title run menu
- Create a duplicate command, ${id}.short whose title is a shorter
  version suitable for context menus
- Fixes #406

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
@alejandro-du
Copy link

How can I hide the icon though?

@rgrunber
Copy link
Member

rgrunber commented Apr 4, 2022

How can I hide the icon though?

Currently it isn't possible to hide this. The icon should only show up in a Java source file when a Quarkus project is detected. I noticed we don't check whether vscode-openshift is installed but the icon does prompt to handle that if clicked.

@fbricon , is it worth having a setting just to disable the icon ?

The only other options I can think of are :

  1. The icon should only appear if the openshift connector is already installed. Currently we don't check that because clicking the icon triggers a prompt asking whether installation should happen
  2. Add a 3rd option (in addition to Yes, No) called Never, which never prompts again to install the connector, and additionally ensures the icon doesn't show up again for the given instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rgrunber rgrunber

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.10.0
Development

Successfully merging a pull request may close this issue.

Make "Deploy to OpenShift" command more discoverable rgrunber/vscode-quarkus
3 participants
@fbricon @rgrunber @alejandro-du