Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Exclude file from validation" for Qute templates results in "Request codeAction/resolve failed." #598

Closed
datho7561 opened this issue Mar 17, 2023 · 1 comment · Fixed by redhat-developer/quarkus-ls#823
Closed

"Exclude file from validation" for Qute templates results in "Request codeAction/resolve failed." #598

datho7561 opened this issue Mar 17, 2023 · 1 comment · Fixed by redhat-developer/quarkus-ls#823
Assignees
@datho7561
Labels
bug Something isn't working qute
Milestone
1.13.0

Comments

@datho7561
Copy link
Contributor

When I exclude a Qute template file from validation using the code action, I get a popup saying that code action resolve failed. However, the .vscode/settings.json is updated appropriately, so it seems like the code action has succeeded.
@datho7561 datho7561 added bug Something isn't working qute labels Mar 17, 2023
@datho7561 datho7561 self-assigned this Mar 21, 2023
@datho7561
Copy link
Contributor Author

datho7561 commented Mar 21, 2023 •
edited

One solution to this is adding an empty WorkspaceEdit to each code action that runs a command but doesn't perform a workspace edit. For whatever reason, VS Code is still trying to resolve these code actions. I'm not sure if that's a bug or intended behaviour, I'll double check the LSP specification.

Update: at least from what I read, its not explicit about what should happen.

@datho7561 datho7561 mentioned this issue Mar 21, 2023
Merged
datho7561 added a commit to datho7561/quarkus-ls that referenced this issue Mar 21, 2023
@datho7561
Prevent resolving code actions that run commands
bf2fa45 
Some clients, like VS Code, will attempt to resolve a code action if
`edit` is missing, even if a command is provided.
In order to prevent this from happening, pass an empty `WorkspaceEdit`
object as the `edit` for code actions that run commands.

Fixes redhat-developer/vscode-quarkus#598

Signed-off-by: David Thompson <davthomp@redhat.com>
angelozerr pushed a commit to redhat-developer/quarkus-ls that referenced this issue Mar 22, 2023
@datho7561 @angelozerr
Prevent resolving code actions that run commands
e6114a1 
Some clients, like VS Code, will attempt to resolve a code action if
`edit` is missing, even if a command is provided.
In order to prevent this from happening, pass an empty `WorkspaceEdit`
object as the `edit` for code actions that run commands.

Fixes redhat-developer/vscode-quarkus#598

Signed-off-by: David Thompson <davthomp@redhat.com>
@angelozerr angelozerr added this to the 1.13.0 milestone Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@datho7561 datho7561

Labels
bug Something isn't working qute
Projects
IDE Raptors
Status: ✅ Done
Milestone
1.13.0
Development

Successfully merging a pull request may close this issue.

Prevent resolving code actions that run commands datho7561/quarkus-ls
2 participants
@angelozerr @datho7561