Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uri comparison #149

Merged
merged 1 commit into from
Nov 12, 2019
Merged

Fix uri comparison #149

merged 1 commit into from
Nov 12, 2019

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Nov 12, 2019

Signed-off-by: Anatoliy Bazko abazko@redhat.com

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
@fbricon
Copy link
Collaborator

fbricon commented Nov 12, 2019

Can you please add a description of the issue in the PR, so that we have some context

@tolusha
Copy link
Contributor Author

tolusha commented Nov 12, 2019

I tried to run the extension in the Theia IDE and figured out that extension can't find a task that had been generated. Some how it works in VS Code but in Theia TaskWorkpace and WorkspaceFolder contain different instances of the same URI. So, we have to compare them using toString() function.

@fbricon fbricon added the bug Something isn't working label Nov 12, 2019
@fbricon fbricon added this to the 1.2.0 milestone Nov 12, 2019
@fbricon fbricon merged commit f5d888c into redhat-developer:master Nov 12, 2019
@fbricon
Copy link
Collaborator

fbricon commented Nov 12, 2019

Thanks @tolusha !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants