Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contributing guide #208

Merged
merged 1 commit into from
Feb 21, 2020
Merged

Update contributing guide #208

merged 1 commit into from
Feb 21, 2020

Conversation

xorye
Copy link
Contributor

@xorye xorye commented Feb 10, 2020

Signed-off-by: David Kwon dakwon@redhat.com

@xorye
Copy link
Contributor Author

xorye commented Feb 10, 2020

@angelozerr do you think there is something that should be added?

@xorye
Copy link
Contributor Author

xorye commented Feb 11, 2020

I made more updates.

However, I realized that this part:
image

Is outdated, because ApplicationConfig is now in io.quarkus.runtime: https://github.com/quarkusio/quarkus/blob/master/core/runtime/src/main/java/io/quarkus/runtime/ApplicationConfig.java.

What should be the new groupId and artifactId?

CONTRIBUTING.md Outdated Show resolved Hide resolved
@xorye
Copy link
Contributor Author

xorye commented Feb 13, 2020

Please wait, I am updating this once more

@xorye
Copy link
Contributor Author

xorye commented Feb 13, 2020

Updated

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated
[ApplicationPropertiesTextDocumentService#completion](https://github.com/redhat-developer/quarkus-ls/blob/9eb7718a6e0faa300f3937e607c3bfffc25c2f1d/microprofile.ls/com.redhat.microprofile.ls/src/main/java/com/redhat/microprofile/ls/ApplicationPropertiesTextDocumentService.java#L150).
This class receives LSP requests for `application.properties` files.

The completion items are being determined from the MicroProfile jdt.ls extension, which searches Quarkus project
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the completion is triggered, it search in their MicroProfile LS cache the properties for the given application.properties. If cache is not filled, it call the microprofile/projectInfo request to call the JDT LS Extension projectInfo delegate command handler in otherwise the manager which collect MicroProfile, Quarkus properties for a given java project.

This manager is extensible by the extension point com.redhat.microprofile.jdt.core.propertiesProviders:

Copy link
Contributor Author

@xorye xorye Feb 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How's this?
image

@fbricon fbricon added this to the 1.4.0 milestone Feb 20, 2020
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
Signed-off-by: David Kwon <dakwon@redhat.com>
@angelozerr angelozerr merged commit fdb9c10 into redhat-developer:master Feb 21, 2020
@angelozerr angelozerr added the documentation Improvements or additions to documentation label Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants