-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update contributing guide #208
Conversation
@angelozerr do you think there is something that should be added? |
I made more updates. However, I realized that this part: Is outdated, because ApplicationConfig is now in io.quarkus.runtime: https://github.com/quarkusio/quarkus/blob/master/core/runtime/src/main/java/io/quarkus/runtime/ApplicationConfig.java. What should be the new groupId and artifactId? |
Please wait, I am updating this once more |
Updated |
CONTRIBUTING.md
Outdated
[ApplicationPropertiesTextDocumentService#completion](https://github.com/redhat-developer/quarkus-ls/blob/9eb7718a6e0faa300f3937e607c3bfffc25c2f1d/microprofile.ls/com.redhat.microprofile.ls/src/main/java/com/redhat/microprofile/ls/ApplicationPropertiesTextDocumentService.java#L150). | ||
This class receives LSP requests for `application.properties` files. | ||
|
||
The completion items are being determined from the MicroProfile jdt.ls extension, which searches Quarkus project |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the completion is triggered, it search in their MicroProfile LS cache the properties for the given application.properties. If cache is not filled, it call the microprofile/projectInfo
request to call the JDT LS Extension projectInfo delegate command handler in otherwise the manager which collect MicroProfile, Quarkus properties for a given java project.
This manager is extensible by the extension point com.redhat.microprofile.jdt.core.propertiesProviders
:
- com.redhat.microprofile.jdt.core define properties provider for MicroProfile.
- com.redhat.microprofile.jdt.quarkus define properties provider for Quarkus.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: David Kwon <dakwon@redhat.com>
Signed-off-by: David Kwon dakwon@redhat.com