Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix terminal not appearing when adding extensions with the Add Extensions command #252

Merged
merged 1 commit into from
Apr 30, 2020
Merged

Conversation

xorye
Copy link
Contributor

@xorye xorye commented Apr 30, 2020

Signed-off-by: David Kwon dakwon@redhat.com

@fbricon fbricon added the bug Something isn't working label Apr 30, 2020
@fbricon fbricon added this to the 1.5.0 milestone Apr 30, 2020
@fbricon
Copy link
Collaborator

fbricon commented Apr 30, 2020

LGTM but please also update the changelog

@xorye
Copy link
Contributor Author

xorye commented Apr 30, 2020

Updated the changelog

Signed-off-by: David Kwon <dakwon@redhat.com>
@xorye xorye changed the title Fix terminal not appearing when adding extensions Fix terminal not appearing when adding extensions with the Add Extensions command Apr 30, 2020
@fbricon fbricon merged commit daadbe7 into redhat-developer:master Apr 30, 2020
@fbricon
Copy link
Collaborator

fbricon commented Apr 30, 2020

Can't reproduce the issue with the fix, nice work @xorye!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants