Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention required NodeJS 14.x in CONTRIBUTING.md #357

Conversation

dgolovin
Copy link
Contributor

@dgolovin dgolovin commented May 8, 2021

When using NodeJS version higher than 14 npm install fails to install @nut-tree/opencv-build-linux package

Signed-off-by: Denis Golovin dgolovin@redhat.com

CONTRIBUTING.md Outdated Show resolved Hide resolved
@angelozerr
Copy link
Contributor

It seems that I have similar problem with

  • Windows OS
  • NodeJS v10.16.0
  • npm 7.19.0

npm ERR! path C:\Users\azerr\git\vscode-quarkus\node_modules\opencv4nodejs-prebuilt
npm ERR! command failed
npm ERR! command C:\WINDOWS\system32\cmd.exe /d /s /c prebuild-install || (node ./install/dependencies.js && node ./install/install.js)
npm ERR! Installing prebuilt OpenCV vundefined for plattform win32
npm ERR! (node:19068) ExperimentalWarning: The fs.promises API is experimental
npm ERR! npm WARN old lockfile 
npm ERR! npm WARN old lockfile The package-lock.json file was created with an old version of npm,
npm ERR! npm WARN old lockfile so supplemental metadata must be fetched from the registry.
npm ERR! npm WARN old lockfile 
npm ERR! npm WARN old lockfile This is a one-time fix-up, please be patient...
npm ERR! npm WARN old lockfile 
npm ERR! npm ERR! code ETARGET
npm ERR! npm ERR! notarget No matching version found for @nut-tree/opencv-build-win32@undefined.
npm ERR! npm ERR! notarget In most cases you or one of your dependencies are requesting
npm ERR! npm ERR! notarget a package version that doesn't exist.
npm ERR! 
npm ERR! npm ERR! A complete log of this run can be found in:
npm ERR! npm ERR!     C:\Users\azerr\AppData\Local\npm-cache\_logs\2021-08-04T12_30_47_838Z-debug.log
npm ERR! child_process.js:669
npm ERR!     throw err;
npm ERR!     ^
npm ERR! 
npm ERR! Error: Command failed: npm install @nut-tree/opencv-build-win32@undefined
npm ERR! (node:19068) ExperimentalWarning: The fs.promises API is experimental
npm ERR! npm WARN old lockfile 
npm ERR! npm WARN old lockfile The package-lock.json file was created with an old version of npm,
npm ERR! npm WARN old lockfile so supplemental metadata must be fetched from the registry.

When using NodeJS version higher than 14 `npm install` fails
to install @nut-tree/opencv-build-linux package

Signed-off-by: Denis Golovin dgolovin@redhat.com
Signed-off-by: Denis Golovin dgolovin@redhat.com
@dgolovin dgolovin force-pushed the mention-nodejs-version-in-contributing.md-requirements branch from 9399f03 to 7fce922 Compare August 7, 2021 04:28
@dgolovin
Copy link
Contributor Author

dgolovin commented Aug 7, 2021

@angelozerr I suggest to remove package-lock.json before running 'npm install'. Node.js 10.16.0 works for me.
@datho7561 I put version range int doc.

@angelozerr
Copy link
Contributor

@dgolovin my problem was about npm version (not about node version). Indeed I install as global the npm version 6.14.14 and it works great again.

@datho7561 datho7561 self-requested a review August 9, 2021 12:57
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change looks good in terms of listing the NodeJS requirement. I think we can merge this. We can add another change to list the NPM requirement (6.y.z)

@datho7561 datho7561 added this to the 1.9.1 milestone Aug 9, 2021
@datho7561 datho7561 added the documentation Improvements or additions to documentation label Aug 9, 2021
@datho7561 datho7561 merged commit 66049bb into redhat-developer:master Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants