Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the npm-watch task #417

Merged
merged 1 commit into from
Nov 19, 2021
Merged

Conversation

rgrunber
Copy link
Member

  • Remove the no longer available --info-verbosity flag (since updating
    webpack-cli)
  • Remove problemWatcher since we can no longer track compilation without
    the verbosity flag
  • Also use a JDK 11 for builds now that we've updated to Tycho 2.x

Signed-off-by: Roland Grunberg rgrunber@redhat.com

- Remove the no longer available --info-verbosity flag (since updating
  webpack-cli)
- Remove problemWatcher since we can no longer track compilation without
  the verbosity flag
- Also use a JDK 11 for builds now that we've updated to Tycho 2.x

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
Copy link
Contributor

@AlexXuChen AlexXuChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rgrunber rgrunber merged commit 5874a71 into redhat-developer:master Nov 19, 2021
@rgrunber rgrunber deleted the fix-npm-watch branch November 19, 2021 14:45
@rgrunber rgrunber added this to the 1.9.1 milestone Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants