Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support for HTTP for code.quarkus.io API endpoints #422

Merged
merged 1 commit into from
Nov 30, 2021

Conversation

fbricon
Copy link
Collaborator

@fbricon fbricon commented Nov 29, 2021

Fix http support to enable testing against a locally built code.quarkus.io endpoint.
See quarkusio/code.quarkus.io#680 (comment)

Signed-off-by: Fred Bricon fbricon@gmail.com

@rgrunber
Copy link
Member

Makes sense to me. Found a similar snippet in https://github.com/redhat-developer/vscode-xml/blob/master/src/server/binary/binaryServerStarter.ts#L265-L270 . Not sure why the test failed..

@AlexXuChen
Copy link
Contributor

I'm seeing an error thrown from javaServerStarter.ts#49:
Screenshot from 2021-11-29 14-15-29
Just checked and I didn't see this on master.

@rgrunber
Copy link
Member

rgrunber commented Nov 29, 2021

I'm seeing an error thrown from javaServerStarter.ts#49: Screenshot from 2021-11-29 14-15-29
Just checked and I didn't see this on master.

Did you pull the latest changes ? The error comes from the qute support and isn't related to this.

@AlexXuChen
Copy link
Contributor

Did you pull the latest changes ? The error comes from the qute support and isn't related to this.

Ah okay, no longer seeing the error. However the local ui test is timing out, same as on the runner.

@rgrunber
Copy link
Member

rgrunber commented Nov 29, 2021

Yup, I'm seeing the same locally without this change, so at least it isn't related. My guess, some odd behaviour in newer VS Code release.

@rgrunber
Copy link
Member

rgrunber commented Nov 30, 2021

I found the issue. It affects vscode-java when no workspace is defined, which is how we run our wizard tests. As soon as I push a (temporary) fix to the test settings, we can rebase this. When we release a new vscode-java, we can get rid of the fix.

#423

Signed-off-by: Fred Bricon <fbricon@gmail.com>
@rgrunber rgrunber added this to the 1.9.1 milestone Nov 30, 2021
@rgrunber rgrunber merged commit d0a8630 into redhat-developer:master Nov 30, 2021
@fbricon fbricon added the bug Something isn't working label Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants