Changed Qute pop-up to appear on text document open #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexXuChen
force-pushed
the
pop-up-timeout
branch
from
8748b97
to
1bdfa1e
Compare
|
If you rebase against the latest version, it should be good again. |
AlexXuChen
force-pushed
the
pop-up-timeout
branch
from
2a7dff3
to
f6e2ac8
Compare
|
The tests still fail with my side, potentially we just stay with your fix then @rgrunber and I can just close this pr? |
rgrunber
reviewed
Mar 28, 2022
There was a problem hiding this comment.
With this change, if I simple activate the Quarkus extension by going to the welcome page, and then open an independent XML file, the experimental validation popup comes up. That shouldn't happen.
The purpose of this PR would be to only bring up the popup if the opened file is a Qute template, so there should be some code that checks whether that's the case.
AlexXuChen
force-pushed
the
pop-up-timeout
branch
2 times, most recently
from
c5d6616
to
518b1f0
Compare
AlexXuChen
changed the title
AlexXuChen
force-pushed
the
pop-up-timeout
branch
from
518b1f0
to
f8d3a38
Compare
rgrunber
reviewed
Apr 11, 2022
AlexXuChen
force-pushed
the
pop-up-timeout
branch
from
f8d3a38
to
51ec548
Compare
AlexXuChen
force-pushed
the
pop-up-timeout
branch
from
51ec548
to
702c9fe
Compare
… timeout Signed-off-by: Alexander Chen <alchen@redhat.com>
AlexXuChen
force-pushed
the
pop-up-timeout
branch
from
702c9fe
to
34c2e8e
Compare
rgrunber
approved these changes
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed Qute pop-up to appear on text document open to fix for UI test timeout
Signed-off-by: Alexander Chen alchen@redhat.com