Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clickable InlayHint for Java type #533

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

angelozerr
Copy link
Contributor

Clickable InlayHint for Java type

Fixes #702

Signed-off-by: azerr azerr@redhat.com

@datho7561
Copy link
Contributor

Is this PR ready? If so, could you please mark it as ready for review?

@angelozerr angelozerr marked this pull request as ready for review August 17, 2022 14:02
@angelozerr
Copy link
Contributor Author

Yes it is ready. I switched to real pr

Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few comments that need to be fixed, but otherwise it appears to be good

src/qute/languageServer/inlayHintsProvider.ts Outdated Show resolved Hide resolved
src/qute/languageServer/inlayHintsProvider.ts Outdated Show resolved Hide resolved
Fixes redhat-developer#702

Signed-off-by: azerr <azerr@redhat.com>
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks, Angelo!

@datho7561 datho7561 added the enhancement New feature or request label Aug 17, 2022
@datho7561 datho7561 added this to the 1.12.0 milestone Aug 17, 2022
@datho7561 datho7561 added the qute label Aug 17, 2022
@datho7561
Copy link
Contributor

Requires redhat-developer/quarkus-ls#704

@datho7561 datho7561 merged commit f57b552 into redhat-developer:master Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request qute
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants