Read files without triggering onDidOpenTextDocument. #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datho7561
reviewed
Feb 8, 2023
|
I don't think I see popups, but I do see something on the left of the bottom bar. Is this what you are mentioning? If so, then this PR does prevent that from happening. |
rgrunber
force-pushed
the
use-fs-reads
branch
from
909e557
to
6eae5f0
Compare
datho7561
reviewed
Feb 8, 2023
src/extension.ts
Outdated
| @@ -157,14 +158,21 @@ async function isQuarkusProject(): Promise<boolean> { | |||
| if (!workspace.workspaceFolders) { | |||
| return false; | |||
| } | |||
| for (const ws of workspace.workspaceFolders) { | |||
| Promise.all(workspace.workspaceFolders.map(async ws => { | |||
There was a problem hiding this comment.
Make sure to return the value of this promise
- vscode.workspace.openTextDocument(..) will trigger the vscode.workspace.onDidOpenTextDocument(..) callback - Some extensions (eg. vscode-java) may relay on this (particularly for pom files) in order to activate other functionality generating a false positive (ie. pom file was "opened") Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
rgrunber
force-pushed
the
use-fs-reads
branch
from
6eae5f0
to
1118036
Compare
datho7561
approved these changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Roland Grunberg rgrunber@redhat.com
I was able to reproduce this by having vscode-quarkus + vscode-pde installed (with all associated dependencies), and then opening eclipse.jdt.ls as a project, and ensuring that some Java source file is opened. Once the project is loaded, you should see a flurry of notifications opening and disappearing very quickly. They all appear to be from the vscode-java dependency analytics prompt.