Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Java version selection in new project wizard #641

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

fbricon
Copy link
Collaborator

@fbricon fbricon commented Feb 1, 2024

Feb-01-2024.12-53-08.mp4

@fbricon fbricon force-pushed the java-quickpick branch 2 times, most recently from 604b56b to 2389ca1 Compare February 1, 2024 13:36
@fbricon
Copy link
Collaborator Author

fbricon commented Feb 1, 2024

1st PR push UI tests failed, but after that happened, vscode 1.86.0 was released. Since then the tests fail no matter what

npm run test-ui
npm WARN config init.version Use `--init-version` instead.

> vscode-quarkus@1.17.0 test-ui
> rm -rf out && npm run test-compile && npm run test-ui-run

npm WARN config init.version Use `--init-version` instead.

> vscode-quarkus@1.17.0 test-compile
> tsc -p ./

npm WARN config init.version Use `--init-version` instead.

> vscode-quarkus@1.17.0 test-ui-run
> extest setup-and-run 'out/test/vscodeUiTest/suite/*.js' -u -e 'out/test/vscodeUiTest/extensions' -o src/test/vscodeUiTest/settings.json

Downloading VSCode: 1.86.0 / stable
VS Code exists in local cache, skipping download
HTTPError: Response code 404 (Not Found)
    at Request._onResponseBase (/Users/fbricon/Dev/projects/vscode-quarkus/node_modules/got/dist/source/core/index.js:913:31)
    at Request._onResponse (/Users/fbricon/Dev/projects/vscode-quarkus/node_modules/got/dist/source/core/index.js:948:24)
    at ClientRequest.<anonymous> (/Users/fbricon/Dev/projects/vscode-quarkus/node_modules/got/dist/source/core/index.js:962:23)
    at Object.onceWrapper (node:events:632:26)
    at ClientRequest.emit (node:events:529:35)
    at origin.emit (/Users/fbricon/Dev/projects/vscode-quarkus/node_modules/@szmarczak/http-timer/dist/source/index.js:43:20)
    at HTTPParser.parserOnIncomingClient (node:_http_client:700:27)
    at HTTPParser.parserOnHeadersComplete (node:_http_common:119:17)
    at TLSSocket.socketOnData (node:_http_client:541:22)
    at TLSSocket.emit (node:events:517:28)

Tests also fail on the GHA runners. I tried to fix the UI tests as much as I could but so far I haven't been able to run them.

I'm inclined to disable UI tests for a while.

@fbricon fbricon added the enhancement New feature or request label Feb 1, 2024
@fbricon fbricon added this to the 1.17.0 milestone Feb 1, 2024
Signed-off-by: Fred Bricon <fbricon@gmail.com>
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well for me. Thanks, Fred!

@datho7561 datho7561 merged commit c0518cc into redhat-developer:master Feb 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants