Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up linting for vscode-xml #438

Closed
datho7561 opened this issue Mar 12, 2021 · 0 comments · Fixed by #744
Closed

Set up linting for vscode-xml #438

datho7561 opened this issue Mar 12, 2021 · 0 comments · Fixed by #744
Assignees
@datho7561
Labels
build
Milestone
0.22.0

Comments

@datho7561
Copy link
Contributor

It might be worthwhile to set up a linter, such as ESLint for vscode-xml.
@datho7561 datho7561 added enhancement New feature or request build labels Mar 12, 2021
datho7561 added a commit to datho7561/vscode-xml that referenced this issue Jun 7, 2021
@datho7561
Use eslint instead of tslint
d2cadfb 
Run `npm run lint` in order to lint the source files.

In VS Code, use Ctrl+Shift+P > "Tasks: Run Task" > "npm: lint"
in order to lint the source files and show the errors in the editor.

Closes redhat-developer#438

Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561 datho7561 mentioned this issue Jun 8, 2021
Closed
@datho7561 datho7561 self-assigned this Jun 8, 2021
datho7561 added a commit to datho7561/vscode-xml that referenced this issue Jul 19, 2022
@datho7561
Replace tslint with eslint
3d6b33d 
One part of redhat-developer#438

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/vscode-xml that referenced this issue Jul 20, 2022
@datho7561
Replace tslint with eslint
d9863ba 
Configure VS Code integration for eslint.
Add a GitHub Actions workflow that runs the TypeScript compile and
eslint.

Closes redhat-developer#438

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/vscode-xml that referenced this issue Jul 20, 2022
@datho7561
Replace tslint with eslint
b9212b8 
Configure VS Code integration for eslint.
Add a GitHub Actions workflow that runs the TypeScript compile and
eslint.

Closes redhat-developer#438

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/vscode-xml that referenced this issue Jul 20, 2022
@datho7561
Replace tslint with eslint
7db6693 
Configure VS Code integration for eslint.
Add a GitHub Actions workflow that runs the TypeScript compile and
eslint.

Closes redhat-developer#438

Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561 datho7561 mentioned this issue Jul 20, 2022
Merged
datho7561 added a commit to datho7561/vscode-xml that referenced this issue Aug 15, 2022
@datho7561
Replace tslint with eslint
69ce156 
Configure VS Code integration for eslint.
Add a GitHub Actions workflow that runs the TypeScript compile and
eslint.

Closes redhat-developer#438

Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561 datho7561 added this to the 0.22.0 milestone Aug 16, 2022
datho7561 added a commit that referenced this issue Aug 16, 2022
@datho7561
Replace tslint with eslint (#744)
9eb434d 
Configure VS Code integration for eslint.
Add a GitHub Actions workflow that runs the TypeScript compile and
eslint.

Closes #438

Signed-off-by: David Thompson <davthomp@redhat.com>
@angelozerr angelozerr removed the enhancement New feature or request label Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@datho7561 datho7561

Labels
build
Projects
None yet
Milestone
0.22.0
2 participants
@angelozerr @datho7561