Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preferences to insert whitespace in self closing tags #85

Merged

Conversation

NikolasKomonen
Copy link
Contributor

Fixes #84

Copy link
Collaborator

@fbricon fbricon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requires a matching PR, server-side

@fbricon
Copy link
Collaborator

fbricon commented Nov 14, 2018

Please also add it to the readme and wiki

README.md Outdated
@@ -54,9 +54,9 @@ The following settings are supported:
* `xml.format.enabled` : Enable/disable formatting.
* `xml.autoCloseTags.enabled` : Enable/disable automatic tag closing.
**Note** 'editor.autoClosingBrackets' must be turned off to work.

Since 0.2.0:
* `xml.server.vmargs`: Extra VM arguments used to launch the XML Language Server. Requires VS Code restart.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add new line

@NikolasKomonen NikolasKomonen force-pushed the spaceBeforeEmptyCloseTag branch 2 times, most recently from cec2319 to fab3526 Compare November 14, 2018 21:54
Signed-off-by: Nikolas Komonen <nikolaskomonen@gmail.com>
@fbricon fbricon merged commit cf783d9 into redhat-developer:master Nov 14, 2018
@NikolasKomonen NikolasKomonen deleted the spaceBeforeEmptyCloseTag branch January 23, 2019 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants