fix array completion in the middle of the empty text

[p-spacek]

What does this PR do?

fix array completion when the cursor is in the middle of the empty text

before:

array.indent.notok.mov

after:

array.indent.ok.mov

schema for this test

"arrayObj": {
      "type": "array",
      "items": {
        "type": "object",
        "properties": {
          "item1": {
            "type": "string"
          },
          "item2": {
            "type": "string",
          }
        },
        "required": [
          "item1",
          "item2"
        ]
      }
    },

What issues does this PR fix or reference?

no ref

Is it tested? How?

added UT,
modified existing one

[p-spacek]

The previous index 19 is probably not correct. index 20 is the end of the content

[coveralls]

Coverage decreased (-0.1%) to 82.083% when pulling 4df39af on p-spacek:fix/completion-array-in-the-middle-of-the-empty-text into 098496e on redhat-developer:main.

[gorkem]

This has cases where it does not insert valid YAML

[gorkem]

I do not think this is going to be enough to insert a valid yaml. The overwriteRange.start.character should be adjusted so that there is no extra space between - and the inserted value.

[p-spacek]

thanks, I'll have a look

[p-spacek]

Do you mean this one?

Screen.Recording.2022-04-08.at.11.22.09.mov

hard to say, it looks ugly (extra indent), but the yaml is valid I think

[gorkem]

Yes, in my tests when I inject a single item editor marks it as invalid.