change completion that is invoked just after array symbol #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gorkem
approved these changes
Apr 7, 2022
| @@ -71,6 +71,7 @@ export class YamlCompletion { | |||
| private configuredIndentation: string | undefined; | |||
| private yamlVersion: YamlVersion; | |||
| private indentation: string; | |||
| private prefixIndentation = ''; | |||
There was a problem hiding this comment.
Should this get a better name to indicate that this prefix is used for arrays only.
There was a problem hiding this comment.
I thought that this property can be used for very similar functionality in the future:
colon without space
simpleProp:#invoke here without spacebut I can change the name to arrayPrefixIndentantion and when this functionality is implemented in the future we can change it back to something more generic.
What do you think?
There was a problem hiding this comment.
Unless you are planning to provide a PR for it soon. I would prefer descriptive names.
There was a problem hiding this comment.
Not sure when, so I renamed it.
msivasubramaniaan
approved these changes
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
unify how codecompletion is displayed in this two situations:
- #curstor-#curstorcurrent implementation:
Screen.Recording.2022-04-06.at.15.08.13.mov
after this update:
Screen.Recording.2022-04-06.at.15.10.56.mov
What issues does this PR fix or reference?
this PR extends:
#696
#697
but it's working separately
Is it tested? How?
modified existing unit tests
I also tested all 3 changes together. I didn't want to put it all together because it's quite different modifications.