OPCT-191: Build and publish the CLI image to registry #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
mtulio
changed the title
mtulio
added
kind/feature
mtulio
changed the title
mtulio
force-pushed
the
OPCT-191-feat-publush-quay
branch
3 times, most recently
from
64a71e1
to
d7a1ccf
Compare
mtulio
added
kind/cleanup
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
Richard, ptal? |
|
/assign @faermanj |
rvanderp3
reviewed
Apr 4, 2023
openshift-merge-robot
added
the
needs-rebase
mtulio
force-pushed
the
OPCT-191-feat-publush-quay
branch
from
dec3afb
to
a408572
Compare
openshift-merge-robot
removed
the
needs-rebase
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rvanderp3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-robot
merged commit 2958396
into
redhat-openshift-ecosystem:main
1 check passed
openshift-merge-robot
pushed a commit
that referenced
this pull request
Apr 10, 2023
Removing dependency on OCP CI registry images (`registry.ci.openshift.org`) when building the project introduced on #51 . It would be nice to unblock external contributors to use the tool when need to build it locally. We don't expect to fall into Docker limitations as that image should be used in a developer environment. https://issues.redhat.com/browse/OPCT-191 ``` $ make linux-amd64-container podman build -t quay.io/ocp-cert/opct:latest -f hack/Containerfile --build-arg=RELEASE_TAG=0.0.0 . [1/2] STEP 1/5: FROM registry.ci.openshift.org/ocp/builder:rhel-8-golang-1.19-openshift-4.13 AS builder Trying to pull registry.ci.openshift.org/ocp/builder:rhel-8-golang-1.19-openshift-4.13... Error: error creating build container: initializing source docker://registry.ci.openshift.org/ocp/builder:rhel-8-golang-1.19-openshift-4.13: reading manifest rhel-8-golang-1.19-openshift-4.13 in registry.ci.openshift.org/ocp/builder: unauthorized: authentication required make: *** [Makefile:49: linux-amd64-container] Error 125 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/OPCT-191
This PR introduces the CLI container image, publishing it on Quay.io to allow be mirrored by OpenShift CI jobs (openshift/release#37955), decreasing the complexity and logic of the CI steps.
https://quay.io/repository/ocp-cert/opct?tab=tags