Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OPCT-191: mirror opct image to be used on steps #37955

Merged
merged 2 commits into from
Apr 5, 2023
Merged

OPCT-191: mirror opct image to be used on steps #37955

merged 2 commits into from
Apr 5, 2023

Conversation

mtulio
Copy link
Contributor

@mtulio mtulio commented Mar 31, 2023 •
edited

opct is the tool used to validate external cloud providers using VCSP Program.

We need to mirror this binary to avoid downloading from Github every step (run, retrieve, results, and more to come) defined on #36894 .

https://issues.redhat.com/browse/OPCT-178
https://issues.redhat.com/browse/OPCT-191

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 31, 2023 •
edited by openshift-ci bot

@mtulio: This pull request references opct-178 which is a valid jira issue.

In response to this:

opct is the tool used to validate external cloud providers using VCSP Program.

We need to mirror this binary to avoid downloading from Github every step (run, retrieve, results, and more to come) defined on #36894 .

https://issues.redhat.com/browse/OPCT-178

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 31, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 31, 2023
@openshift-ci-robot
Copy link
Contributor

@mtulio, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

couldn't prepare candidate: couldn't rebase repo client
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse refresh to get an updated list of affected jobs (useful if you have new pushes to the branch)

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@mtulio mtulio changed the title opct-178: mirror cli image to be used on steps OPCT-178: mirror cli image to be used on steps Mar 31, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 31, 2023 •
edited by openshift-ci bot

@mtulio: This pull request references OPCT-178 which is a valid jira issue.

In response to this:

opct is the tool used to validate external cloud providers using VCSP Program.

We need to mirror this binary to avoid downloading from Github every step (run, retrieve, results, and more to come) defined on #36894 .

https://issues.redhat.com/browse/OPCT-178

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 31, 2023
@mtulio
Copy link
Contributor Author

mtulio commented Mar 31, 2023

Ptal @bbguimaraes @droslean?
/assign @bbguimaraes @droslean

@mtulio mtulio mentioned this pull request Mar 31, 2023
Merged
1 task
@mtulio mtulio changed the title OPCT-178: mirror cli image to be used on steps OPCT-191: mirror cli image to be used on steps Mar 31, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 31, 2023 •
edited by openshift-ci bot

@mtulio: This pull request references OPCT-191 which is a valid jira issue.

In response to this:

opct is the tool used to validate external cloud providers using VCSP Program.

We need to mirror this binary to avoid downloading from Github every step (run, retrieve, results, and more to come) defined on #36894 .

https://issues.redhat.com/browse/OPCT-178

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 31, 2023 •
edited by openshift-ci bot

@mtulio: This pull request references OPCT-191 which is a valid jira issue.

In response to this:

opct is the tool used to validate external cloud providers using VCSP Program.

We need to mirror this binary to avoid downloading from Github every step (run, retrieve, results, and more to come) defined on #36894 .

https://issues.redhat.com/browse/OPCT-178
https://issues.redhat.com/browse/OPCT-191

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mtulio mtulio changed the title OPCT-191: mirror cli image to be used on steps OPCT-191: mirror opct image to be used on steps Mar 31, 2023
@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 3, 2023
@mtulio mtulio mentioned this pull request Apr 4, 2023
Merged
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2023
@mtulio
Copy link
Contributor Author

mtulio commented Apr 4, 2023

Ptal @bbguimaraes @droslean? The lgtm flag was gone after rebase

@mtulio mtulio requested a review from droslean April 4, 2023 13:34
openshift-merge-robot pushed a commit to redhat-openshift-ecosystem/provider-certification-tool that referenced this pull request Apr 4, 2023
@mtulio
OPCT-191: Build and publish the CLI image to registry (#51)
2958396 
https://issues.redhat.com/browse/OPCT-191

This PR introduces the CLI container image, publishing it on Quay.io to
allow be mirrored by OpenShift CI jobs
(openshift/release#37955), decreasing the
complexity and logic of the CI steps.

https://quay.io/repository/ocp-cert/opct?tab=tags
@rvanderp3
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: droslean, mtulio, rvanderp3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mtulio
Copy link
Contributor Author

mtulio commented Apr 5, 2023 •
edited

Ptal @bbguimaraes @droslean? lgtm tag was removed after rebase.

@mtulio
Copy link
Contributor Author

mtulio commented Apr 5, 2023

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 5, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 5, 2023

@mtulio: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 57362e8 into openshift:master Apr 5, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 5, 2023

@mtulio: Updated the image-mirror-mappings configmap in namespace ci at cluster app.ci using the following files:

  • key mapping_supplemental_ci_images_ci using file core-services/image-mirroring/supplemental-ci-images/mapping_supplemental_ci_images_ci

In response to this:

opct is the tool used to validate external cloud providers using VCSP Program.

We need to mirror this binary to avoid downloading from Github every step (run, retrieve, results, and more to come) defined on #36894 .

https://issues.redhat.com/browse/OPCT-178
https://issues.redhat.com/browse/OPCT-191

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mtulio mtulio deleted the opct-178-mirror-cli branch April 5, 2023 14:12
mtulio added a commit to mtulio/release that referenced this pull request Apr 6, 2023
@mtulio
extracting opct from ImageStream openshift#37955
244c7c8
openshift-merge-robot pushed a commit that referenced this pull request Apr 11, 2023
@mtulio
OPCT-178: review periodics to add 4.10 and run in opct release (#36894)
d7ff64c 
* feat/OPCT-178: run in stable release and improving report

opct: spliting install and results from run

adding support for 4.10 for regular execution

fix: make jobs

review owners: removing bostrt

re-enable the notification to slack

* extracting opct from ImageStream #37955

* opct: cleanup install and report steps

* opct: final review for regular execution mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbguimaraes bbguimaraes Awaiting requested review from bbguimaraes

@droslean droslean Awaiting requested review from droslean

Assignees

@bbguimaraes bbguimaraes

@droslean droslean

@rvanderp3 rvanderp3

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
6 participants
@mtulio @openshift-ci-robot @rvanderp3 @droslean @bbguimaraes @openshift-merge-robot