Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OPCT-199: added EFS removing bindata dependency #73

Merged
merged 3 commits into from
Jul 24, 2023
Merged

OPCT-199: added EFS removing bindata dependency #73

merged 3 commits into from
Jul 24, 2023

Conversation

mtulio
Copy link
Contributor

@mtulio mtulio commented Jul 15, 2023 •
edited

The goal of this PR is to replace bindata dependency to Go native embed file system to handle static files used in OPCT (manifest plugins).

Changes in this PR:

  • [blocker] remove bindata dependency, and workaround added to cover missing fixes caught by Go static checks
  • introduce embed filesystem to manage static data (plugin manifest templates)
  • improve the template handling, covering the entire manifest file, providing flexibility to apply hooks in the manifest in runtime (required for future goals like injecting dynamic scripts or manifests to run dynamic/extended tests)
  • increase unit tests coverage for static files and template processing
  • deprecate assets command (non-documented and used - plugins may not work independently, it don't need to export it to user)
  • expand CI jobs to keep clearly what is running, run in parallel, and keep clear the running jobs in the PRs

@mtulio mtulio added kind/dependency-change Categorizes issue or PR as related to changing dependencies category/tech-debt labels Jul 15, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 15, 2023
@mtulio mtulio marked this pull request as ready for review July 15, 2023 05:17
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 15, 2023
@mtulio mtulio force-pushed the opct-199-bindata-fix branch 4 times, most recently from d85e370 to 1dfd72f Compare July 15, 2023 05:43
@mtulio mtulio changed the title OPCT-199: added VFS removing bindata dependency OPCT-199: added EFS removing bindata dependency Jul 15, 2023
@mtulio mtulio force-pushed the opct-199-bindata-fix branch 6 times, most recently from ad7deaa to 9fac459 Compare July 24, 2023 15:00
@mtulio
Copy link
Contributor Author

mtulio commented Jul 24, 2023

/assign @faermanj @rvanderp3

@rvanderp3
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jul 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rvanderp3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2023
@openshift-merge-robot openshift-merge-robot merged commit 2d524f4 into redhat-openshift-ecosystem:main Jul 24, 2023
4 checks passed
@mtulio mtulio deleted the opct-199-bindata-fix branch July 24, 2023 16:27
@mtulio mtulio mentioned this pull request Jul 24, 2023
Merged
openshift-merge-robot pushed a commit that referenced this pull request Jul 24, 2023
@mtulio
OPCT-199: CI - added linter job and update workflow dependencies (#75)
57088a7 
Create CI improvements identified in
#73
(quick win):

- Remove duplicated steps in the job
- Add linter job
- Create job chain, requiring [linter and static check] to run [tests
and vet]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faermanj faermanj Awaiting requested review from faermanj

@rvanderp3 rvanderp3 Awaiting requested review from rvanderp3

Assignees

@faermanj faermanj

@rvanderp3 rvanderp3

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. category/tech-debt kind/dependency-change Categorizes issue or PR as related to changing dependencies lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mtulio @rvanderp3 @faermanj @openshift-merge-robot