OPCT-199: CI - added linter job and update workflow dependencies #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
mtulio
added
category/tech-debt
component/CI
kind/cleanup
mtulio
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rvanderp3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
mtulio
commented
Jul 24, 2023
Comment on lines
+542
to
+547
| _ = sheet.SetCellValue(sheeName, fmt.Sprintf("A%d", *rowN), suite) | ||
| _ = sheet.SetCellValue(sheeName, fmt.Sprintf("B%d", *rowN), idx+1) | ||
| _ = sheet.SetCellValue(sheeName, fmt.Sprintf("C%d", *rowN), sheeName) | ||
| _ = sheet.SetCellValue(sheeName, fmt.Sprintf("D%d", *rowN), v) | ||
| _ = sheet.SetCellValue(sheeName, fmt.Sprintf("E%d", *rowN), "TODO Review") | ||
| _ = sheet.SetCellValue(sheeName, fmt.Sprintf("F%d", *rowN), "") |
There was a problem hiding this comment.
those lines will be removed soon - when the HTML report will be delivered - and spreadsheet banished! =)
mtulio
changed the title
mtulio
changed the title
openshift-merge-robot
merged commit 57088a7
into
redhat-openshift-ecosystem:main
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create CI improvements identified in #73 (quick win):