Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[packstack] Install dashboard plugins for projects deployed by packstack #14

Closed
5 tasks done
amoralej opened this issue Jul 25, 2017 · 7 comments
Closed
5 tasks done
Assignees
Labels

Comments

@amoralej
Copy link
Collaborator

amoralej commented Jul 25, 2017

What to improve

Packstack does not install horizon plugins when deploying services. For example, when enabling magnum installation by using CONFIG_MAGNUM_INSTALL option in answer file, magnum services are installed and configured but package openstack-magnum-ui is not installed.

Currently, following services have dashboard plugins in RDO which should be installed as part of horizon deployment when enabled:

project horizon plugin package
magnum openstack-magnum-ui
sahara openstack-sahara-ui
ironic openstack-ironic-ui
trove openstack-trove-ui
lbaas openstack-neutron-lbaas-ui

Hint about implementation

Packstack provides a puppet manifest to install and configure horizon using puppet-horizon . That manifest should check if services are enabled in hiera, as for example using hiera('CONFIG_MAGNUM_INSTALL') and if it's enabled make sure the package openstack-magnum-ui is installed.

Contributing

Packstack is an OpenStack project and follows the peer-review process based on reviews in OpenStack gerrit. Instructions about how to contribute to packstack can be found in the wiki page.

Mentors

  • amoralej

  • neutron-lbaas-ui

  • magnum-ui

  • ironic-ui

  • trove-ui

  • sahara-ui

@OGtrilliams
Copy link

I will happily do all of these!

OGtrilliams added a commit to OGtrilliams/packstack that referenced this issue Jul 25, 2017
@OGtrilliams
Copy link

Would you mind pointing out an example for reference?

@amoralej
Copy link
Collaborator Author

Here you have an example used in openstackclient manifest to install manilaclient when CONFIG_MANILA_INSTALL is enabled:

https://github.com/openstack/packstack/blob/master/packstack/puppet/modules/packstack/manifests/openstackclient.pp#L9-L11

In this case you'd need something similar but for other services and package names, as shown in the issue description. It should go in https://github.com/openstack/packstack/blob/master/packstack/puppet/modules/packstack/manifests/horizon.pp

@OGtrilliams
Copy link

Awesome, thanks Alfredo. I was close but I was putting it in the wrong file. i tested all of these on Ocata- seems they all work OK.

neutron-lbaas-ui - https://review.openstack.org/488517
magnum-ui - https://review.openstack.org/488523
ironic-ui - https://review.openstack.org/488532
trove-ui - https://review.openstack.org/488536
sahara-ui - https://review.openstack.org/488558

openstack-gerrit pushed a commit to redhat-openstack/packstack that referenced this issue Aug 3, 2017
Will automatically install neutron-lbaas-ui if neutron-lbaas is enabled.

Per RDO request redhat-openstack/easyfix#14

Change-Id: If3ba0d77bb11e4b226d4627fcd005c269ee0b25a
openstack-gerrit pushed a commit to redhat-openstack/packstack that referenced this issue Aug 3, 2017
Added function to automatically install magnum-ui dashboard plugins
when Magnum is enabled.

Per RDO request redhat-openstack/easyfix#14

Change-Id: Ida389f5d63615a0931a630ede07744f1138a6f9c
openstack-gerrit pushed a commit to redhat-openstack/packstack that referenced this issue Aug 9, 2017
Will install ironic-ui if ironic is enabled

Per RDO request redhat-openstack/easyfix#14

Change-Id: I8ec8313da3e14a438c7e854b09a8f58350259e6c
@snecklifter
Copy link
Contributor

Just waiting on Trove and Sahara now.

@OGtrilliams just a couple of minor nits on those commits I think...

openstack-gerrit pushed a commit to redhat-openstack/packstack that referenced this issue Aug 14, 2017
will install trove-ui when Trove is enabled.

Per RDO request redhat-openstack/easyfix#14

Change-Id: I5a7f9b8aba04ab9870cd00f02bec7ccfdd731b36
openstack-gerrit pushed a commit to redhat-openstack/packstack that referenced this issue Aug 14, 2017
will install sahara-ui when Sahara is enabled

Per RDO request redhat-openstack/easyfix#14

Change-Id: Ie76641738411184ef757b40087ea1f03423dda39
@snecklifter
Copy link
Contributor

@amoralej any more or are you happy to close this one?

@amoralej
Copy link
Collaborator Author

@OGtrilliams thanks for these patches, they will be included in packstack version in pike.

OGtrilliams added a commit to OGtrilliams/packstack that referenced this issue May 17, 2019
Will automatically install neutron-lbaas-ui if neutron-lbaas is enabled.

Per RDO request redhat-openstack/easyfix#14

Change-Id: If3ba0d77bb11e4b226d4627fcd005c269ee0b25a
OGtrilliams added a commit to OGtrilliams/packstack that referenced this issue May 17, 2019
Added function to automatically install magnum-ui dashboard plugins
when Magnum is enabled.

Per RDO request redhat-openstack/easyfix#14

Change-Id: Ida389f5d63615a0931a630ede07744f1138a6f9c
OGtrilliams added a commit to OGtrilliams/packstack that referenced this issue May 17, 2019
Will install ironic-ui if ironic is enabled

Per RDO request redhat-openstack/easyfix#14

Change-Id: I8ec8313da3e14a438c7e854b09a8f58350259e6c
OGtrilliams added a commit to OGtrilliams/packstack that referenced this issue May 17, 2019
will install trove-ui when Trove is enabled.

Per RDO request redhat-openstack/easyfix#14

Change-Id: I5a7f9b8aba04ab9870cd00f02bec7ccfdd731b36
OGtrilliams added a commit to OGtrilliams/packstack that referenced this issue May 17, 2019
will install sahara-ui when Sahara is enabled

Per RDO request redhat-openstack/easyfix#14

Change-Id: Ie76641738411184ef757b40087ea1f03423dda39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants