Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding abiltiy to bind driver with dpdk-devbind.py that resides in th… #161

Merged
merged 8 commits into from
Jun 2, 2023

Conversation

PatrickKutch
Copy link
Collaborator

I created a new way of binding the driver. There is now a bind_driver_with_dpdk() that uses the dpdk-devbind.py tool that is designed for doing this.

Also created a new execute function called executeWithSearch() that can search stdout for a specified error string - because you cannot get an errorcode from an application run in a container

I've not changed any of the other code (except test_utils::test_bind_driver) to make user of the new bind_driver_with_dpdk(). I wanted to get you guys to look at what I did before we change bind_driver() calls to bind_driver_with_dpdk()

@PatrickKutch
Copy link
Collaborator Author

I fixed some of the lintr complaints, but many of these errors are not in my new sections, not sure why this is failing.

@akiselev1
Copy link
Collaborator

@PatrickKutch It is possible that we updated linter settings after the initial code was committed. Would you mind running black formatter against the file?
"'sriov.common.utils.bind_driver' imported but unused" is introduced by your change. Please remove if not used.

@PatrickKutch
Copy link
Collaborator Author

Updated.

@PatrickKutch
Copy link
Collaborator Author

I'm a little confused why the lint for me fails on things I didn't touch.

@akiselev1
Copy link
Collaborator

I'm a little confused why the lint for me fails on things I didn't touch.

@PatrickKutch Let's look at exec.py linter failures. Flake8 reported violations at lines 299. 300, 311. Looking at your diff, these lines are part of the new executeWithSearch. Likewise, utils.py lines 58,76,79 were brought by bind_driver_with_dpdk in your diff. Let me know if I miss anything. I can show you in real time how to make flake8 sriov --count --select=E,C,F,W --ignore W503 --max-complexity=15 --max-line-length=88 --show-source --statistics pass on your fork.

@jianzzha
Copy link
Member

jianzzha commented Jun 1, 2023

looks good

Copy link
Collaborator

@dkosteck dkosteck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look like good additions

@akiselev1 akiselev1 added the e2e-test Ready for an end-to-end test label Jun 2, 2023
@akiselev1
Copy link
Collaborator

LGTM! @PatrickKutch please proceed with merge.

@PatrickKutch
Copy link
Collaborator Author

Merging in ability to use the driver binding capability in dpdk

@PatrickKutch PatrickKutch merged commit 57ba62a into redhat-partner-solutions:main Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e-test Ready for an end-to-end test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants