-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding abiltiy to bind driver with dpdk-devbind.py that resides in th… #161
Conversation
I fixed some of the lintr complaints, but many of these errors are not in my new sections, not sure why this is failing. |
@PatrickKutch It is possible that we updated linter settings after the initial code was committed. Would you mind running black formatter against the file? |
Updated. |
I'm a little confused why the lint for me fails on things I didn't touch. |
@PatrickKutch Let's look at exec.py linter failures. Flake8 reported violations at lines 299. 300, 311. Looking at your diff, these lines are part of the new executeWithSearch. Likewise, utils.py lines 58,76,79 were brought by bind_driver_with_dpdk in your diff. Let me know if I miss anything. I can show you in real time how to make |
looks good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look like good additions
LGTM! @PatrickKutch please proceed with merge. |
Merging in ability to use the driver binding capability in dpdk |
I created a new way of binding the driver. There is now a bind_driver_with_dpdk() that uses the dpdk-devbind.py tool that is designed for doing this.
Also created a new execute function called executeWithSearch() that can search stdout for a specified error string - because you cannot get an errorcode from an application run in a container
I've not changed any of the other code (except test_utils::test_bind_driver) to make user of the new bind_driver_with_dpdk(). I wanted to get you guys to look at what I did before we change bind_driver() calls to bind_driver_with_dpdk()