v249 rebase CI test #9

mrc0mmand · 2021-07-02T09:50:04Z

CI test for the upcoming v249 rebase, don't merge.

lgtm-com · 2021-07-02T10:33:53Z

This pull request introduces 3 alerts and fixes 8 when merging 81c345f into 5aa097c - view on LGTM.com

new alerts:

3 for FIXME comment

fixed alerts:

6 for Use of potentially dangerous function
1 for Use of potentially dangerous function
1 for FIXME comment

mrc0mmand · 2021-07-02T10:52:20Z

10:29:57 Detected man-only PR, skipping integration tests

Oh well, looks like v249 is not that big of a change ;)

The previous string was "unknown", but that's wrong, because we *do* know what we are going to do with those partitions: we leave them unmodified, hence say "unchanged" in the output, to be clearer.

link_up_or_down() will decrement the counter when the subsequent RTM_GETLINK netlink method is finished. So, we need to increment the counter here. Fixes the issue mentioned at systemd/systemd#19832 (comment).

This also renames link_reconfigure_internal() -> link_reconfigure_impl().

Fixes the issue mentioned at systemd/systemd#19832 (comment).

some newer architectures like riscv32 do not have __NR_ppoll from get go

…ource type But it does nothing for an event source which is neither a timer nor ratelimited.

Before 81107b8, the compare functions for the latest or earliest prioq did not handle ratelimited flag. So, it was ok to not reshuffle the time prioq when changing the flag. But now, those two compare functions also compare the source is ratelimited or not. So, it is necessary to reshuffle the time prioq after changing the ratelimited flag. Hopefully fixes #19903.

Prompted by #19911.

ret_nodes is NULL terminated, the return value isn't a count.

Fixes #19920.

This reverts commit 592d419. The commit makes journald unstable, and is just an optimization for the size of journal. Hence, it is safe to revert the commit. Fixes #19895.

…seat to be set" This reverts commit b25389d.

systemd/systemd@154b2f6#commitcomment-52902617

C.f. systemd/systemd#19980 (comment)

This fixes a bug introduced by fe321d4. When we want to update a value (in the case of this commit, it is a hardware address) which is used as a hashmap key, we need to do the following steps: 1. remove the old hashmap entry, 2. update the value, 3. create a new hashmap entry with the new value.

Followup for bc98983. The original reproducer still works w/o the unref, and doesn't work with this change.

This will be useful for tests to skip missing time zones.

Fixes #20089. This is essentially a packaging bug in CentOS: the db lists a timezone which is not present in /usr/share/zoneinfo. Let's skip this gracefully.

Output can always be kranked up with LOG_LEVEL=debug. But let's make less predictable noise by default.

As requested in systemd/systemd#20058 (review).

This reverts commit 7f1e9c806b6915e8020cf3706dc87e1cd37bc2fa, PR #6750 Apparently the rule change never worked, see #20071. Fixes #20071

…A250 sensor Recently the kernel has gotten support for reading the mount-matrix for BMA250 sensors represented by a BOSC0200 ACPI device from the ACPI tables, so that we don't need to add quirks for these. At least that was the theory. The Chuwi Hi13 (CWI534) with BMA250 sensor has the sensor mounted such that it works / needs the normal(ized) matrix, but the ACPI tables actually contain a wrong matrix inverting the X and Y axis. Add a quirk to override /sys/bus/iio/devices/iio:device?/in_mount_matrix with the norm-matrix, since the ACPI derived matrix is actually wrong on these devices (sigh)

lgtm-com · 2021-07-02T12:58:32Z

This pull request introduces 3 alerts and fixes 8 when merging 8b9c746 into 5aa097c - view on LGTM.com

new alerts:

3 for FIXME comment

fixed alerts:

6 for Use of potentially dangerous function
1 for Use of potentially dangerous function
1 for FIXME comment

lgtm-com · 2021-07-02T15:58:12Z

This pull request introduces 3 alerts and fixes 8 when merging 2e496c5 into 5aa097c - view on LGTM.com

new alerts:

3 for FIXME comment

fixed alerts:

6 for Use of potentially dangerous function
1 for Use of potentially dangerous function
1 for FIXME comment

mrc0mmand · 2021-07-02T16:43:59Z

Great, v249 fixes the outstanding CI issues we have in RHEL 9, so we just have to wait for the main release.

``` timedatectl list-timezones --no-pager ... ==164329==ERROR: LeakSanitizer: detected memory leaks Direct leak of 8192 byte(s) in 1 object(s) allocated from: #0 0x7fe8a74b6f8c in reallocarray (/lib64/libasan.so.6+0xaef8c) #1 0x7fe8a63485dc in strv_push ../src/basic/strv.c:419 #2 0x7fe8a6349419 in strv_consume ../src/basic/strv.c:490 #3 0x7fe8a634958d in strv_extend ../src/basic/strv.c:542 #4 0x7fe8a643d787 in bus_message_read_strv_extend ../src/libsystemd/sd-bus/bus-message.c:5606 #5 0x7fe8a643db9d in sd_bus_message_read_strv ../src/libsystemd/sd-bus/bus-message.c:5628 #6 0x4085fb in list_timezones ../src/timedate/timedatectl.c:314 #7 0x7fe8a61ef3e1 in dispatch_verb ../src/shared/verbs.c:103 #8 0x410f91 in timedatectl_main ../src/timedate/timedatectl.c:1025 #9 0x41111c in run ../src/timedate/timedatectl.c:1043 #10 0x411242 in main ../src/timedate/timedatectl.c:1046 #11 0x7fe8a489df1f in __libc_start_call_main (/lib64/libc.so.6+0x40f1f) ``` (cherry picked from commit a2e37d5) Related: #2087652

This wrapper is used in situations where we don't care about *San reports, we just want to make things work. However, with enabled LSan we might trigger some bogus reports we're definitely not interested in, causing unexpected test fails. Spotted on C8S in TEST-34-DYNAMICUSERMIGRATE: ``` [10654.804162] testsuite-34.sh[56]: + systemctl start testservice-34-check-writable.service Starting testservice-34-check-writable.service... [10655.055969] bash[546]: + set -o pipefail [10655.056127] bash[546]: + declare -a writable_dirs [10655.056234] bash[546]: + readarray -t writable_dirs [10655.060838] bash[548]: ++ find / '(' -path /var/tmp -o -path /tmp -o -path /proc -o -path /dev/mqueue -o -path /dev/shm -o -path /sys/fs/bpf -o -path /dev/.lxc -o -path /sys/devices/system/cpu ')' -prune -o -type d -writable -print [10655.061534] bash[549]: ++ sort -u [10655.688740] bash[547]: ================================================================= [10655.689075] bash[547]: ==547==ERROR: LeakSanitizer: detected memory leaks [10655.689246] bash[547]: Direct leak of 112 byte(s) in 1 object(s) allocated from: [10655.743851] bash[547]: #0 0x7ffff752d364 (/usr/lib64/clang/14.0.0/lib/libclang_rt.asan-powerpc64le.so+0x13d364) (BuildId: 321f4ed1caea6a1a4c37f9272e07275cf16f034d) [10655.744060] bash[547]: redhat-plumbers#1 0x1000b5d20 in xmalloc (/usr/bin/bash+0xb5d20) (BuildId: da38eb38f6870bdc2a6ef51c52aa6ce20921fe40) [10655.744224] bash[547]: redhat-plumbers#2 0x100083338 (/usr/bin/bash+0x83338) (BuildId: da38eb38f6870bdc2a6ef51c52aa6ce20921fe40) [10655.744393] bash[547]: redhat-plumbers#3 0x10008847c (/usr/bin/bash+0x8847c) (BuildId: da38eb38f6870bdc2a6ef51c52aa6ce20921fe40) [10655.744552] bash[547]: redhat-plumbers#4 0x1000af6ec in redirection_expand (/usr/bin/bash+0xaf6ec) (BuildId: da38eb38f6870bdc2a6ef51c52aa6ce20921fe40) [10655.744728] bash[547]: redhat-plumbers#5 0x1000b005c (/usr/bin/bash+0xb005c) (BuildId: da38eb38f6870bdc2a6ef51c52aa6ce20921fe40) [10655.744886] bash[547]: redhat-plumbers#6 0x1000b1388 in do_redirections (/usr/bin/bash+0xb1388) (BuildId: da38eb38f6870bdc2a6ef51c52aa6ce20921fe40) [10655.745051] bash[547]: redhat-plumbers#7 0x100050484 (/usr/bin/bash+0x50484) (BuildId: da38eb38f6870bdc2a6ef51c52aa6ce20921fe40) [10655.745208] bash[547]: redhat-plumbers#8 0x100052160 in execute_command_internal (/usr/bin/bash+0x52160) (BuildId: da38eb38f6870bdc2a6ef51c52aa6ce20921fe40) [10655.745376] bash[547]: redhat-plumbers#9 0x100052a10 in execute_command_internal (/usr/bin/bash+0x52a10) (BuildId: da38eb38f6870bdc2a6ef51c52aa6ce20921fe40) [10655.745536] bash[547]: redhat-plumbers#10 0x100053e38 in execute_command (/usr/bin/bash+0x53e38) (BuildId: da38eb38f6870bdc2a6ef51c52aa6ce20921fe40) [10655.745711] bash[547]: redhat-plumbers#11 0x1000529d8 in execute_command_internal (/usr/bin/bash+0x529d8) (BuildId: da38eb38f6870bdc2a6ef51c52aa6ce20921fe40) [10655.745870] bash[547]: redhat-plumbers#12 0x100053e38 in execute_command (/usr/bin/bash+0x53e38) (BuildId: da38eb38f6870bdc2a6ef51c52aa6ce20921fe40) [10655.746038] bash[547]: redhat-plumbers#13 0x1000529d8 in execute_command_internal (/usr/bin/bash+0x529d8) (BuildId: da38eb38f6870bdc2a6ef51c52aa6ce20921fe40) [10655.746198] bash[547]: redhat-plumbers#14 0x100053e38 in execute_command (/usr/bin/bash+0x53e38) (BuildId: da38eb38f6870bdc2a6ef51c52aa6ce20921fe40) [10655.746367] bash[547]: redhat-plumbers#15 0x1000529d8 in execute_command_internal (/usr/bin/bash+0x529d8) (BuildId: da38eb38f6870bdc2a6ef51c52aa6ce20921fe40) [10655.746548] bash[547]: redhat-plumbers#16 0x100053e38 in execute_command (/usr/bin/bash+0x53e38) (BuildId: da38eb38f6870bdc2a6ef51c52aa6ce20921fe40) [10655.746741] bash[547]: redhat-plumbers#17 0x1000529d8 in execute_command_internal (/usr/bin/bash+0x529d8) (BuildId: da38eb38f6870bdc2a6ef51c52aa6ce20921fe40) [10655.746897] bash[547]: redhat-plumbers#18 0x100053e38 in execute_command (/usr/bin/bash+0x53e38) (BuildId: da38eb38f6870bdc2a6ef51c52aa6ce20921fe40) [10655.747067] bash[547]: redhat-plumbers#19 0x1000529d8 in execute_command_internal (/usr/bin/bash+0x529d8) (BuildId: da38eb38f6870bdc2a6ef51c52aa6ce20921fe40) [10655.747227] bash[547]: redhat-plumbers#20 0x100053e38 in execute_command (/usr/bin/bash+0x53e38) (BuildId: da38eb38f6870bdc2a6ef51c52aa6ce20921fe40) [10655.747414] bash[547]: redhat-plumbers#21 0x1000529d8 in execute_command_internal (/usr/bin/bash+0x529d8) (BuildId: da38eb38f6870bdc2a6ef51c52aa6ce20921fe40) [10655.747573] bash[547]: redhat-plumbers#22 0x100053e38 in execute_command (/usr/bin/bash+0x53e38) (BuildId: da38eb38f6870bdc2a6ef51c52aa6ce20921fe40) [10655.747741] bash[547]: redhat-plumbers#23 0x1000529d8 in execute_command_internal (/usr/bin/bash+0x529d8) (BuildId: da38eb38f6870bdc2a6ef51c52aa6ce20921fe40) [10655.747896] bash[547]: redhat-plumbers#24 0x100053e38 in execute_command (/usr/bin/bash+0x53e38) (BuildId: da38eb38f6870bdc2a6ef51c52aa6ce20921fe40) [10655.748064] bash[547]: redhat-plumbers#25 0x1000529d8 in execute_command_internal (/usr/bin/bash+0x529d8) (BuildId: da38eb38f6870bdc2a6ef51c52aa6ce20921fe40) [10655.748225] bash[547]: redhat-plumbers#26 0x100053e38 in execute_command (/usr/bin/bash+0x53e38) (BuildId: da38eb38f6870bdc2a6ef51c52aa6ce20921fe40) [10655.748390] bash[547]: redhat-plumbers#27 0x1000529d8 in execute_command_internal (/usr/bin/bash+0x529d8) (BuildId: da38eb38f6870bdc2a6ef51c52aa6ce20921fe40) [10655.748553] bash[547]: redhat-plumbers#28 0x1000bf91c in parse_and_execute (/usr/bin/bash+0xbf91c) (BuildId: da38eb38f6870bdc2a6ef51c52aa6ce20921fe40) [10655.748717] bash[547]: redhat-plumbers#29 0x1000311ec (/usr/bin/bash+0x311ec) (BuildId: da38eb38f6870bdc2a6ef51c52aa6ce20921fe40) [10655.748883] bash[547]: Direct leak of 17 byte(s) in 1 object(s) allocated from: ... ```

On faster machines we might be too fast and kill the fake binary during fork() which then makes kernel report a "wrong" binary in the coredump, e.g.: [ 31.408078] testsuite-74.sh[548]: + /tmp/make-dump /tmp/test-dump SIGTRAP [ 31.409720] testsuite-74.sh[560]: + bin=/tmp/test-dump [ 31.409720] testsuite-74.sh[560]: + sig=SIGTRAP [ 31.409720] testsuite-74.sh[560]: + ulimit -c unlimited [ 31.409720] testsuite-74.sh[560]: + pid=561 [ 31.409720] testsuite-74.sh[560]: + sleep 1 [ 31.409720] testsuite-74.sh[560]: + kill -s SIGTRAP 561 [ 31.409720] testsuite-74.sh[560]: + wait 561 [ 31.491757] systemd[1]: Created slice system-systemd\x2dcoredump.slice. [ 31.524488] systemd[1]: Started systemd-coredump@0-563-0.service. [ 31.616372] systemd-coredump[564]: [🡕] Process 561 (make-dump) of user 0 dumped core. Stack trace of thread 561: #0 0x00007ff86bb49af7 _Fork (libc.so.6 + 0xd4af7) #1 0x00007ff86bb4965f __libc_fork (libc.so.6 + 0xd465f) #2 0x000055e88011b0ad make_child (bash + 0x550ad) #3 0x000055e8800fd05f n/a (bash + 0x3705f) #4 0x000055e880100116 execute_command_internal (bash + 0x3a116) #5 0x000055e8801011f2 execute_command_internal (bash + 0x3b1f2) #6 0x000055e8801025b6 execute_command (bash + 0x3c5b6) #7 0x000055e8800f134b reader_loop (bash + 0x2b34b) #8 0x000055e8800e757d main (bash + 0x2157d) #9 0x00007ff86ba98850 n/a (libc.so.6 + 0x23850) #10 0x00007ff86ba9890a __libc_start_main (libc.so.6 + 0x2390a) #11 0x000055e8800e83b5 _start (bash + 0x223b5) ELF object binary architecture: AMD x86-64 [ 31.666617] testsuite-74.sh[560]: /tmp/make-dump: line 12: 561 Trace/breakpoint trap (core dumped) "$bin" infinity ... $ coredumpctl list --file system.journal TIME PID UID GID SIG COREFILE EXE SIZE Fri 2023-06-02 10:42:10 CEST 561 0 0 SIGTRAP journal /usr/bin/bash - Fri 2023-06-02 10:42:11 CEST 570 0 0 SIGABRT journal /tmp/test-dump - Fri 2023-06-02 10:42:12 CEST 582 0 0 SIGTRAP missing /tmp/test-dump - Fri 2023-06-02 10:42:13 CEST 593 0 0 SIGABRT missing /tmp/test-dump - (cherry picked from commit 1326d2d) Related: RHEL-29430

On faster machines we might be too fast and kill the fake binary during fork() which then makes kernel report a "wrong" binary in the coredump, e.g.: [ 31.408078] testsuite-74.sh[548]: + /tmp/make-dump /tmp/test-dump SIGTRAP [ 31.409720] testsuite-74.sh[560]: + bin=/tmp/test-dump [ 31.409720] testsuite-74.sh[560]: + sig=SIGTRAP [ 31.409720] testsuite-74.sh[560]: + ulimit -c unlimited [ 31.409720] testsuite-74.sh[560]: + pid=561 [ 31.409720] testsuite-74.sh[560]: + sleep 1 [ 31.409720] testsuite-74.sh[560]: + kill -s SIGTRAP 561 [ 31.409720] testsuite-74.sh[560]: + wait 561 [ 31.491757] systemd[1]: Created slice system-systemd\x2dcoredump.slice. [ 31.524488] systemd[1]: Started systemd-coredump@0-563-0.service. [ 31.616372] systemd-coredump[564]: [🡕] Process 561 (make-dump) of user 0 dumped core. Stack trace of thread 561: #0 0x00007ff86bb49af7 _Fork (libc.so.6 + 0xd4af7) #1 0x00007ff86bb4965f __libc_fork (libc.so.6 + 0xd465f) #2 0x000055e88011b0ad make_child (bash + 0x550ad) #3 0x000055e8800fd05f n/a (bash + 0x3705f) #4 0x000055e880100116 execute_command_internal (bash + 0x3a116) #5 0x000055e8801011f2 execute_command_internal (bash + 0x3b1f2) #6 0x000055e8801025b6 execute_command (bash + 0x3c5b6) #7 0x000055e8800f134b reader_loop (bash + 0x2b34b) #8 0x000055e8800e757d main (bash + 0x2157d) #9 0x00007ff86ba98850 n/a (libc.so.6 + 0x23850) #10 0x00007ff86ba9890a __libc_start_main (libc.so.6 + 0x2390a) #11 0x000055e8800e83b5 _start (bash + 0x223b5) ELF object binary architecture: AMD x86-64 [ 31.666617] testsuite-74.sh[560]: /tmp/make-dump: line 12: 561 Trace/breakpoint trap (core dumped) "$bin" infinity ... $ coredumpctl list --file system.journal TIME PID UID GID SIG COREFILE EXE SIZE Fri 2023-06-02 10:42:10 CEST 561 0 0 SIGTRAP journal /usr/bin/bash - Fri 2023-06-02 10:42:11 CEST 570 0 0 SIGABRT journal /tmp/test-dump - Fri 2023-06-02 10:42:12 CEST 582 0 0 SIGTRAP missing /tmp/test-dump - Fri 2023-06-02 10:42:13 CEST 593 0 0 SIGABRT missing /tmp/test-dump - (cherry picked from commit 1326d2d) Related: RHEL-34061

On faster machines we might be too fast and kill the fake binary during fork() which then makes kernel report a "wrong" binary in the coredump, e.g.: [ 31.408078] testsuite-74.sh[548]: + /tmp/make-dump /tmp/test-dump SIGTRAP [ 31.409720] testsuite-74.sh[560]: + bin=/tmp/test-dump [ 31.409720] testsuite-74.sh[560]: + sig=SIGTRAP [ 31.409720] testsuite-74.sh[560]: + ulimit -c unlimited [ 31.409720] testsuite-74.sh[560]: + pid=561 [ 31.409720] testsuite-74.sh[560]: + sleep 1 [ 31.409720] testsuite-74.sh[560]: + kill -s SIGTRAP 561 [ 31.409720] testsuite-74.sh[560]: + wait 561 [ 31.491757] systemd[1]: Created slice system-systemd\x2dcoredump.slice. [ 31.524488] systemd[1]: Started systemd-coredump@0-563-0.service. [ 31.616372] systemd-coredump[564]: [🡕] Process 561 (make-dump) of user 0 dumped core. Stack trace of thread 561: #0 0x00007ff86bb49af7 _Fork (libc.so.6 + 0xd4af7) #1 0x00007ff86bb4965f __libc_fork (libc.so.6 + 0xd465f) #2 0x000055e88011b0ad make_child (bash + 0x550ad) #3 0x000055e8800fd05f n/a (bash + 0x3705f) #4 0x000055e880100116 execute_command_internal (bash + 0x3a116) #5 0x000055e8801011f2 execute_command_internal (bash + 0x3b1f2) #6 0x000055e8801025b6 execute_command (bash + 0x3c5b6) #7 0x000055e8800f134b reader_loop (bash + 0x2b34b) #8 0x000055e8800e757d main (bash + 0x2157d) #9 0x00007ff86ba98850 n/a (libc.so.6 + 0x23850) #10 0x00007ff86ba9890a __libc_start_main (libc.so.6 + 0x2390a) #11 0x000055e8800e83b5 _start (bash + 0x223b5) ELF object binary architecture: AMD x86-64 [ 31.666617] testsuite-74.sh[560]: /tmp/make-dump: line 12: 561 Trace/breakpoint trap (core dumped) "$bin" infinity ... $ coredumpctl list --file system.journal TIME PID UID GID SIG COREFILE EXE SIZE Fri 2023-06-02 10:42:10 CEST 561 0 0 SIGTRAP journal /usr/bin/bash - Fri 2023-06-02 10:42:11 CEST 570 0 0 SIGABRT journal /tmp/test-dump - Fri 2023-06-02 10:42:12 CEST 582 0 0 SIGTRAP missing /tmp/test-dump - Fri 2023-06-02 10:42:13 CEST 593 0 0 SIGABRT missing /tmp/test-dump - (cherry picked from commit 1326d2d) Related: RHEL-34059

mrc0mmand force-pushed the rebase-test branch from 027a0b0 to 81c345f Compare July 2, 2021 09:50

systemd-rhel-bot added pr/needs-ci Formerly needs-ci pr/needs-review Formerly needs-review tracker/missing Formerly needs-bz and removed pr/needs-ci Formerly needs-ci labels Jul 2, 2021

mrc0mmand force-pushed the rebase-test branch from 81c345f to b83da84 Compare July 2, 2021 11:17

systemd-rhel-bot added the pr/needs-ci Formerly needs-ci label Jul 2, 2021

poettering and others added 21 commits July 2, 2021 13:39

repart: align all sizes in table to the right

9b50a4a

repart: show partitions we don't grow/create as "unchanged"

758a3d2

The previous string was "unknown", but that's wrong, because we *do* know what we are going to do with those partitions: we leave them unmodified, hence say "unchanged" in the output, to be clearer.

network: add missing increment of Link::set_flags_messages

d8faed3

link_up_or_down() will decrement the counter when the subsequent RTM_GETLINK netlink method is finished. So, we need to increment the counter here. Fixes the issue mentioned at systemd/systemd#19832 (comment).

network: do not partially update wlan information on failure

e236d2c

network: add brief comment about reconfiguring interfaces

109077b

This also renames link_reconfigure_internal() -> link_reconfigure_impl().

network: update wlan information when IFF_LOWER_UP flag is gained

a6e013e

Fixes the issue mentioned at systemd/systemd#19832 (comment).

test-seccomp: Check for __NR_ppoll before use (#19858)

35ced24

some newer architectures like riscv32 do not have __NR_ppoll from get go

sd-event: drop unnecessary "else"

272502e

sd-event: use CMP() macro

95fba0f

sd-event: use usec_add()

1dd33e2

sd-event: make event_source_time_prioq_reshuffle() accept all event s…

6465a1f

…ource type But it does nothing for an event source which is neither a timer nor ratelimited.

tree-wide: add missing whitespace at the end of comments

e34f2f4

fix typo

0d1a6b8

man: add an example to configure default route on device with table

c06bed3

Prompted by #19911.

man: fix sd_bus_add_node_enumerator() ret_nodes

62eb1bf

ret_nodes is NULL terminated, the return value isn't a count.

unit: use alias name of man page

3c9df7b

core/service: fix assertion when Type=dbus but BusName= is not specified

7dce8a9

Fixes #19920.

test: add a test case for #19920

4eaf7dd

Revert "journal-file: truncate archived journals"

1f1f0bd

This reverts commit 592d419. The commit makes journald unstable, and is just an optimization for the size of journal. Hence, it is safe to revert the commit. Fixes #19895.

syscalls: update tables

0e63cb8

poettering and others added 11 commits July 2, 2021 13:39

Revert "login: XGI Z7/Z9 (XG20 core) graphic chip requires master-of-…

8955194

…seat to be set" This reverts commit b25389d.

NEWS: fix misplaces parenthesis

9d558a1

systemd/systemd@154b2f6#commitcomment-52902617

network: ipv4acd: update log message

5dd5d03

C.f. systemd/systemd#19980 (comment)

core: add comment explaining event source deallocation

6ef82a9

Followup for bc98983. The original reproducer still works w/o the unref, and doesn't work with this change.

time-util: add variant of timezone_is_valid() that returns errno

73d6197

This will be useful for tests to skip missing time zones.

test-time-util: skip missing timezones

f6bdca1

Fixes #20089. This is essentially a packaging bug in CentOS: the db lists a timezone which is not present in /usr/share/zoneinfo. Let's skip this gracefully.

test-time-util: log less verbosely

a05ddd5

Output can always be kranked up with LOG_LEVEL=debug. But let's make less predictable noise by default.

core: always set output arg in unit_status_string()

1ef0196

As requested in systemd/systemd#20058 (review).

Revert "rules: ubi mtd - add link to named partitions"

4177a73

This reverts commit 7f1e9c806b6915e8020cf3706dc87e1cd37bc2fa, PR #6750 Apparently the rule change never worked, see #20071. Fixes #20071

mrc0mmand force-pushed the rebase-test branch from b83da84 to 3bfc74b Compare July 2, 2021 11:39

systemd-rhel-bot removed the pr/needs-ci Formerly needs-ci label Jul 2, 2021

mrc0mmand force-pushed the rebase-test branch from 8b9c746 to 3bfc74b Compare July 2, 2021 13:21

systemd-rhel-bot added pr/needs-ci Formerly needs-ci and removed pr/needs-ci Formerly needs-ci labels Jul 2, 2021

NEWS: update for imminent v249-rc3 tag

2e496c5

mrc0mmand force-pushed the rebase-test branch from 3bfc74b to 2e496c5 Compare July 2, 2021 14:48

systemd-rhel-bot added the pr/needs-ci Formerly needs-ci label Jul 2, 2021

systemd-rhel-bot removed the pr/needs-ci Formerly needs-ci label Jul 2, 2021

mrc0mmand closed this Jul 2, 2021

mrc0mmand deleted the rebase-test branch July 2, 2021 16:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

v249 rebase CI test #9

v249 rebase CI test #9

mrc0mmand commented Jul 2, 2021

lgtm-com bot commented Jul 2, 2021

mrc0mmand commented Jul 2, 2021

lgtm-com bot commented Jul 2, 2021

lgtm-com bot commented Jul 2, 2021

mrc0mmand commented Jul 2, 2021

v249 rebase CI test #9

v249 rebase CI test #9

Conversation

mrc0mmand commented Jul 2, 2021

lgtm-com bot commented Jul 2, 2021

mrc0mmand commented Jul 2, 2021

lgtm-com bot commented Jul 2, 2021

lgtm-com bot commented Jul 2, 2021

mrc0mmand commented Jul 2, 2021