Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of IPA server CA #61

Merged
merged 1 commit into from
May 5, 2022
Merged

Implementation of IPA server CA #61

merged 1 commit into from
May 5, 2022

Conversation

x00Pavel
Copy link
Member

This PR brings the implementation of IPAServerCA model with unit tests.

@x00Pavel x00Pavel requested a review from inikolcev April 27, 2022 10:28
@x00Pavel x00Pavel self-assigned this Apr 27, 2022
@lgtm-com
Copy link

lgtm-com bot commented Apr 27, 2022

This pull request introduces 1 alert when merging 08d3b7c into d01406b - view on LGTM.com

new alerts:

  • 1 for Clear-text storage of sensitive information

tox.ini Show resolved Hide resolved
Copy link

@t184256 t184256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a rather superficial review; would need some more introduction into the grand scheme of things to comment on something else than typos

test/test_ca.py Show resolved Hide resolved
test/test_ca.py Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented Apr 28, 2022

This pull request introduces 2 alerts when merging d450f09 into d01406b - view on LGTM.com

new alerts:

  • 1 for Clear-text storage of sensitive information
  • 1 for Accepting unknown SSH host keys when using Paramiko

SCAutolib/models/CA.py Outdated Show resolved Hide resolved
SCAutolib/models/CA.py Show resolved Hide resolved
SCAutolib/models/CA.py Show resolved Hide resolved
SCAutolib/models/CA.py Outdated Show resolved Hide resolved
SCAutolib/models/CA.py Outdated Show resolved Hide resolved
SCAutolib/models/CA.py Outdated Show resolved Hide resolved
SCAutolib/models/CA.py Show resolved Hide resolved
SCAutolib/models/CA.py Show resolved Hide resolved
SCAutolib/models/CA.py Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented Apr 29, 2022

This pull request introduces 2 alerts when merging b9ff3ad into d01406b - view on LGTM.com

new alerts:

  • 1 for Clear-text storage of sensitive information
  • 1 for Accepting unknown SSH host keys when using Paramiko

@lgtm-com
Copy link

lgtm-com bot commented May 2, 2022

This pull request introduces 2 alerts when merging 5510b8b into 799aa72 - view on LGTM.com

new alerts:

  • 1 for Clear-text storage of sensitive information
  • 1 for Accepting unknown SSH host keys when using Paramiko

@lgtm-com
Copy link

lgtm-com bot commented May 2, 2022

This pull request introduces 2 alerts when merging ced2f93 into 799aa72 - view on LGTM.com

new alerts:

  • 1 for Clear-text storage of sensitive information
  • 1 for Accepting unknown SSH host keys when using Paramiko

@lgtm-com
Copy link

lgtm-com bot commented May 2, 2022

This pull request introduces 2 alerts when merging 853dbf6 into 799aa72 - view on LGTM.com

new alerts:

  • 1 for Clear-text storage of sensitive information
  • 1 for Accepting unknown SSH host keys when using Paramiko

Add unit tests for IPA server CA

Disable auxiliary logs from not important loggers

Update docs and logs

Add test for force option

Move IPAServerCA to CA.py

Add assertion for making requests to IPA server via ClientMeta

Update linter

Fix renaming of the cert output

Add unit test for IPA server CA

Remove redundant test

Update for review

Remove hardcoded admin password

Add propagation of default env values to pytest env
@x00Pavel x00Pavel merged commit 0abfd93 into V2 May 5, 2022
@x00Pavel x00Pavel deleted the V2-IPA-CA branch May 5, 2022 12:03
@lgtm-com
Copy link

lgtm-com bot commented May 5, 2022

This pull request introduces 2 alerts when merging 0be9ae3 into 799aa72 - view on LGTM.com

new alerts:

  • 1 for Clear-text storage of sensitive information
  • 1 for Accepting unknown SSH host keys when using Paramiko

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants